mirror/minify
1
0
Fork 0
mirror of https://github.com/mrclay/minify.git synced 2025-08-11 00:24:11 +02:00
Code Issues Releases Wiki Activity

handle more ng exit codes

Browse Source 
comments from #87:

* cbed5408dd
For some reasons Nailgun thinks that it's server
broke the connection and returns 227 instead of 0
We'll just handle this here instead of fixing
the nailgun client itself.

* 7810d4a445
It also sometimes breaks on 229 on the devbox.
To complete this whole madness and made future
'fixes' easier I added this nice little array...
This commit is contained in:
Elan Ruusamäe
2015-11-20 14:04:14 +02:00
parent 5458206700
commit 27b5f4b2d0
1 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Minify/NailgunClosureCompiler.php
View File

@@ -17,9 +17,18 @@ class Minify_NailgunClosureCompiler extends Minify_ClosureCompiler
const NG_SERVER = 'com.martiansoftware.nailgun.NGServer'; const NG_SERVER = 'com.martiansoftware.nailgun.NGServer';
const CC_MAIN = 'com.google.javascript.jscomp.CommandLineRunner'; const CC_MAIN = 'com.google.javascript.jscomp.CommandLineRunner';
// exit code that ng gives /**
// FIXME: figure out the meaning of the value * For some reasons Nailgun thinks that it's server
const NG_EXIT_CODE = 227; * broke the connection and returns 227 instead of 0
* We'll just handle this here instead of fixing
* the nailgun client itself.
*
* It also sometimes breaks on 229 on the devbox.
* To complete this whole madness and made future
* 'fixes' easier I added this nice little array...
* @var array
*/
private static $NG_EXIT_CODES = array(0, 227, 229);
/** /**
* Filepath of "ng" executable (from Nailgun package) * Filepath of "ng" executable (from Nailgun package)
@@ -87,7 +96,7 @@ class Minify_NailgunClosureCompiler extends Minify_ClosureCompiler
$command = $this->getCommand($options, $tmpFile); $command = $this->getCommand($options, $tmpFile);
return implode("\n", $this->shell($command, array(self::NG_EXIT_CODE))); return implode("\n", $this->shell($command, self::$NG_EXIT_CODES));
} }
private function startServer() private function startServer()