From b6ef6fa397fbb273d98fd938b979eb345b3c6168 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elan=20Ruusam=C3=A4e?= Date: Tue, 26 Dec 2017 02:30:50 +0200 Subject: [PATCH 1/3] travis: test php 5.3..7.3 --- .travis.yml | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/.travis.yml b/.travis.yml index 7ff3132..25a5f78 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,21 +1,26 @@ language: php sudo: false +dist: trusty -php: - - 7.0 - - 5.6 - - 5.5 - - 5.4 - - hhvm +jobs: + fast_finish: true + allow_failures: + - php: "hhvm" + include: + - php: "5.3" + dist: precise + - php: "5.4" + - php: "5.5" + - php: "5.6" + - php: "7.0" + - php: "7.1" + - php: "7.2" + - php: "nightly" + - php: "hhvm" env: - CLOSURE_VERSION: 20161024 -matrix: - allow_failures: - - php: hhvm - - php: 7.0 - services: - memcached From eb4c0f6541c21407b35d4acaba59ab0df5c199be Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elan=20Ruusam=C3=A4e?= Date: Fri, 5 Jan 2018 13:03:28 +0200 Subject: [PATCH 2/3] leafo/scssphp: allow 0.3/0.6/0.7 tests/ScssSourceTest.php passed with all versions refs: - commit ddf3a4e57f - PR #562 --- composer.json | 2 +- tests/ScssSourceTest.php | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/composer.json b/composer.json index c8858b6..651f1f8 100644 --- a/composer.json +++ b/composer.json @@ -33,7 +33,7 @@ }, "require-dev": { "firephp/firephp-core": "~0.4.0", - "leafo/scssphp": "~0.6.6", + "leafo/scssphp": "^0.3 || ^0.6 || ^0.7", "marcusschwarz/lesserphp": "~0.5.1", "meenie/javascript-packer": "~1.1", "phpunit/phpunit": "^4.8.36", diff --git a/tests/ScssSourceTest.php b/tests/ScssSourceTest.php index aa2cdf9..2a2dec9 100644 --- a/tests/ScssSourceTest.php +++ b/tests/ScssSourceTest.php @@ -8,10 +8,6 @@ class ScssSourceTest extends TestCase { public function setUp() { - if (version_compare(PHP_VERSION, '5.4.0', '<')) { - $this->markTestSkipped('scssphp is not compatible with this PHP version.'); - } - $this->realDocRoot = $_SERVER['DOCUMENT_ROOT']; $_SERVER['DOCUMENT_ROOT'] = self::$document_root; } From bb7fc743307e989e9479a0cdc2edc4d674e07e57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Elan=20Ruusam=C3=A4e?= Date: Fri, 5 Jan 2018 13:13:20 +0200 Subject: [PATCH 3/3] tests: rename dataproviders not to be picked up as tests --- tests/HTTPEncoderTest.php | 8 ++++---- tests/JSMinTest.php | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/HTTPEncoderTest.php b/tests/HTTPEncoderTest.php index ea150fc..a3b3359 100644 --- a/tests/HTTPEncoderTest.php +++ b/tests/HTTPEncoderTest.php @@ -7,7 +7,7 @@ use HTTP_Encoder; class HTTPEncoderTest extends TestCase { /** - * @dataProvider testToIe6Data + * @dataProvider ToIe6DataProvider * @preserveGlobals */ public function testToIe6($ua, $ae, $exp, $desc) @@ -20,7 +20,7 @@ class HTTPEncoderTest extends TestCase $this->assertSame($exp, $ret, $desc); } - public function testToIe6Data() + public function ToIe6DataProvider() { return array( array( @@ -69,7 +69,7 @@ class HTTPEncoderTest extends TestCase } /** - * @dataProvider testEncodeNonIeData + * @dataProvider EncodeNonIeDataProvider */ public function testEncodeNonIe($ua, $ae, $exp, $desc) { @@ -81,7 +81,7 @@ class HTTPEncoderTest extends TestCase $this->assertSame($exp, $ret, $desc); } - public function testEncodeNonIeData() + public function EncodeNonIeDataProvider() { return array( array( diff --git a/tests/JSMinTest.php b/tests/JSMinTest.php index 271a483..66c19c0 100644 --- a/tests/JSMinTest.php +++ b/tests/JSMinTest.php @@ -57,7 +57,8 @@ class JSMinTest extends TestCase * @param string $label * @param string $expClass * @param string $expMessage - * @dataProvider testJSMinExceptionData + * + * @dataProvider JSMinExceptionDataProvider */ public function testJSMinException($js, $label, $expClass, $expMessage) { @@ -71,7 +72,7 @@ class JSMinTest extends TestCase $this->assertTrue($eClass === $expClass && $eMsg === $expMessage, 'Throw on ' . $label); } - public function testJSMinExceptionData() + public function JSMinExceptionDataProvider() { // $js, $label, $expClass, $expMessage return array(