From 2689aea89a8875ba91a737ee185e710aaa168e58 Mon Sep 17 00:00:00 2001 From: Erik Johansson Date: Sun, 29 Apr 2018 21:45:03 +0200 Subject: [PATCH] Simplify toast text shown when clicking on pie chart Also don't reload measurement views as the selected measurement should already be loaded and reloading discards the previuos measurement. --- .../health/openscale/gui/fragments/OverviewFragment.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/android_app/app/src/main/java/com/health/openscale/gui/fragments/OverviewFragment.java b/android_app/app/src/main/java/com/health/openscale/gui/fragments/OverviewFragment.java index fbf6b92f..1c5ed8c6 100644 --- a/android_app/app/src/main/java/com/health/openscale/gui/fragments/OverviewFragment.java +++ b/android_app/app/src/main/java/com/health/openscale/gui/fragments/OverviewFragment.java @@ -317,16 +317,15 @@ public class OverviewFragment extends Fragment implements FragmentUpdateListener return; } - String date_time = DateFormat.getDateTimeInstance(DateFormat.FULL, DateFormat.SHORT).format(lastScaleMeasurement.getDateTime()); - for (MeasurementView view : measurementViews) { if (view instanceof FloatMeasurementView) { FloatMeasurementView measurementView = (FloatMeasurementView) view; - measurementView.loadFrom(lastScaleMeasurement, null); - if (measurementView.getColor() == arcValue.getColor()) { - Toast.makeText(getActivity(), measurementView.getName() + " " + measurementView.getValueAsString() + measurementView.getUnit() + " " + getResources().getString(R.string.info_on_date) + " " + date_time, Toast.LENGTH_SHORT).show(); + Toast.makeText(getActivity(), String.format("%s: %s %s", + measurementView.getName(), measurementView.getValueAsString(), + measurementView.getUnit()), Toast.LENGTH_SHORT).show(); + break; } } }