From 9e5776d1edd9597ee8d09505810054f38a2746d5 Mon Sep 17 00:00:00 2001 From: Erik Johansson Date: Mon, 16 Apr 2018 20:50:48 +0200 Subject: [PATCH] Close cursor when done with it --- .../java/com/health/openscale/core/OpenScale.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/android_app/app/src/main/java/com/health/openscale/core/OpenScale.java b/android_app/app/src/main/java/com/health/openscale/core/OpenScale.java index f94a6f16..ff72ed47 100644 --- a/android_app/app/src/main/java/com/health/openscale/core/OpenScale.java +++ b/android_app/app/src/main/java/com/health/openscale/core/OpenScale.java @@ -365,8 +365,15 @@ public class OpenScale { public String getFilenameFromUriMayThrow(Uri uri) { Cursor cursor = context.getContentResolver().query( uri, null, null, null, null); - cursor.moveToFirst(); - return cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME)); + try { + cursor.moveToFirst(); + return cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME)); + } + finally { + if (cursor != null) { + cursor.close(); + } + } } public String getFilenameFromUri(Uri uri) {