From acd0c628a69a28913b730624ff59a1505547b13a Mon Sep 17 00:00:00 2001
From: Krisjans Blukis <kblukis@gmail.com>
Date: Tue, 27 Jul 2021 16:33:38 +0300
Subject: [PATCH] BluetoothStandardWeightProfile: make debug messages about
 User Control Point more explicit;

---
 .../BluetoothStandardWeightProfile.java       | 20 ++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/android_app/app/src/main/java/com/health/openscale/core/bluetooth/BluetoothStandardWeightProfile.java b/android_app/app/src/main/java/com/health/openscale/core/bluetooth/BluetoothStandardWeightProfile.java
index 98f7f561..4424d7d4 100644
--- a/android_app/app/src/main/java/com/health/openscale/core/bluetooth/BluetoothStandardWeightProfile.java
+++ b/android_app/app/src/main/java/com/health/openscale/core/bluetooth/BluetoothStandardWeightProfile.java
@@ -233,27 +233,32 @@ public class BluetoothStandardWeightProfile extends BluetoothCommunication {
     protected void handleUserControlPointNotify(byte[] value) {
         if(value[0]==UDS_CP_RESPONSE) {
             switch (value[1]) {
+                case UDS_CP_LIST_ALL_USERS:
+                    Timber.d("UDS_CP_LIST_ALL_USERS value [" + byteInHex(value) + "]");
+                    break;
                 case UDS_CP_REGISTER_NEW_USER:
                     if (value[2] == UDS_CP_RESP_VALUE_SUCCESS) {
                         int userIndex = value[3];
                         int userId = this.selectedUser.getId();
-                        Timber.d(String.format("Created user with ID %d and Index %d", userId, userIndex));
+                        Timber.d(String.format("UDS_CP_REGISTER_NEW_USER: Created scale user index: "
+                                + "%d (app user id: %d)", userIndex, userId));
                         storeUserScaleIndex(userId, userIndex);
                         resumeMachineState();
                     } else {
-                        Timber.e("ERROR: could not register new user");
+                        Timber.e("UDS_CP_REGISTER_NEW_USER: ERROR: could not register new scale user, code: " + value[2]);
                     }
                     break;
                 case UDS_CP_CONSENT:
                     if (registerNewUser) {
+                        Timber.d("UDS_CP_CONSENT: registerNewUser==true, value[2] == " + value[2]);
                         resumeMachineState();
                         break;
                     }
                     if (value[2] == UDS_CP_RESP_VALUE_SUCCESS) {
-                        Timber.d("Success user consent");
+                        Timber.d("UDS_CP_CONSENT: Success user consent");
                         resumeMachineState();
                     } else if (value[2] == UDS_CP_RESP_USER_NOT_AUTHORIZED) {
-                        Timber.e("Not authorized");
+                        Timber.e("UDS_CP_CONSENT: Not authorized");
                         enterScaleUserConsentUi(this.selectedUser.getId(), getUserScaleIndex(this.selectedUser.getId()));
                     }
                     else {
@@ -261,10 +266,15 @@ public class BluetoothStandardWeightProfile extends BluetoothCommunication {
                     }
                     break;
                 default:
-                    Timber.e("Unhandled response");
+                    Timber.e("CHARACTERISTIC_USER_CONTROL_POINT: Unhandled response code "
+                            + value[1] + " value [" + byteInHex(value) + "]");
                     break;
             }
         }
+        else {
+            Timber.d("CHARACTERISTIC_USER_CONTROL_POINT: non-response code " + value[0]
+                    + " value [" + byteInHex(value) + "]");
+        }
     }
 
     protected ScaleMeasurement weightMeasurementToScaleMeasurement(byte[] value) {