From 068ee71bf774ebdc491d5963647a0179aa2b85ee Mon Sep 17 00:00:00 2001
From: Jakub Vrana <jakub@vrana.cz>
Date: Fri, 12 Jan 2018 16:06:00 +0100
Subject: [PATCH] Return false from editingRemoveRow

---
 adminer/include/editing.inc.php | 2 +-
 adminer/indexes.inc.php         | 2 +-
 adminer/static/editing.js       | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/adminer/include/editing.inc.php b/adminer/include/editing.inc.php
index 8a6e4458..4cae2c70 100644
--- a/adminer/include/editing.inc.php
+++ b/adminer/include/editing.inc.php
@@ -280,7 +280,7 @@ echo checkbox("fields[$i][has_default]", 1, $field["has_default"], "", "", "", "
 			. "<input type='image' class='icon' name='up[$i]' src='../adminer/static/up.gif' alt='^' title='" . lang('Move up') . "' onclick='return !editingMoveRow.call(this, 1);'>&nbsp;"
 			. "<input type='image' class='icon' name='down[$i]' src='../adminer/static/down.gif' alt='v' title='" . lang('Move down') . "' onclick='return !editingMoveRow.call(this, 0);'>&nbsp;"
 		: "");
-		echo ($orig == "" || support("drop_col") ? "<input type='image' class='icon' name='drop_col[$i]' src='../adminer/static/cross.gif' alt='x' title='" . lang('Remove') . "' onclick=\"return !editingRemoveRow.call(this, 'fields\$1[field]');\">" : "");
+		echo ($orig == "" || support("drop_col") ? "<input type='image' class='icon' name='drop_col[$i]' src='../adminer/static/cross.gif' alt='x' title='" . lang('Remove') . "' onclick=\"return editingRemoveRow.call(this, 'fields\$1[field]');\">" : "");
 		echo "\n";
 	}
 }
diff --git a/adminer/indexes.inc.php b/adminer/indexes.inc.php
index da82ff21..34512347 100644
--- a/adminer/indexes.inc.php
+++ b/adminer/indexes.inc.php
@@ -132,7 +132,7 @@ foreach ($row["indexes"] as $index) {
 		}
 
 		echo "<td><input name='indexes[$j][name]' value='" . h($index["name"]) . "' autocapitalize='off' aria-labelledby='label-name'>\n";
-		echo "<td><input type='image' class='icon' name='drop_col[$j]' src='../adminer/static/cross.gif' alt='x' title='" . lang('Remove') . "' onclick=\"return !editingRemoveRow.call(this, 'indexes\$1[type]');\">\n";
+		echo "<td><input type='image' class='icon' name='drop_col[$j]' src='../adminer/static/cross.gif' alt='x' title='" . lang('Remove') . "' onclick=\"return editingRemoveRow.call(this, 'indexes\$1[type]');\">\n";
 	}
 	$j++;
 }
diff --git a/adminer/static/editing.js b/adminer/static/editing.js
index e7cfbd48..1cdafc2c 100644
--- a/adminer/static/editing.js
+++ b/adminer/static/editing.js
@@ -258,14 +258,14 @@ function editingAddRow(focus) {
 
 /** Remove table row for field
 * @param string
-* @return boolean
+* @return boolean false
 * @this HTMLInputElement
 */
 function editingRemoveRow(name) {
 	var field = formField(this.form, this.name.replace(/[^\[]+(.+)/, name));
 	field.parentNode.removeChild(field);
 	parentTag(this, 'tr').style.display = 'none';
-	return true;
+	return false;
 }
 
 /** Move table row for field