diff --git a/CHANGELOG.md b/CHANGELOG.md index b5779831..9ed31ddf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,5 @@ ## Adminer dev +- Do not edit NULL values by Modify (bug #967) - MySQL: Display number of found rows in group queries (regression from 5.1.1) ## Adminer 5.1.1 (released 2025-04-02) diff --git a/adminer/select.inc.php b/adminer/select.inc.php index 850960fb..f9d8755c 100644 --- a/adminer/select.inc.php +++ b/adminer/select.inc.php @@ -452,20 +452,20 @@ if (!$columns && support("table")) { } } - $val = select_value($val, $link, $field, $text_length); + $html = select_value($val, $link, $field, $text_length); $id = h("val[$unique_idf][" . bracket_escape($key) . "]"); - $value = idx(idx($_POST["val"], $unique_idf), bracket_escape($key)); - $editable = !is_array($row[$key]) && is_utf8($val) && $rows[$n][$key] == $row[$key] && !$functions[$key] && !$field["generated"]; + $posted = idx(idx($_POST["val"], $unique_idf), bracket_escape($key)); + $editable = !is_array($row[$key]) && is_utf8($html) && $rows[$n][$key] == $row[$key] && !$functions[$key] && !$field["generated"]; $text = preg_match('~text|json|lob~', $field["type"]); - echo "NULL' || is_numeric(strip_tags($val))) ? " class='number'" : ""); - if (($_GET["modify"] && $editable) || $value !== null) { - $h_value = h($value !== null ? $value : $row[$key]); + echo "" . ($text ? "" : ""); } else { - $long = strpos($val, ""); + $long = strpos($html, ""); echo " data-text='" . ($long ? 2 : ($text ? 1 : 0)) . "'" . ($editable ? "" : " data-warning='" . h(lang('Use edit link to modify this value.')) . "'") - . ">$val" + . ">$html" ; } }