mirror/php-auth
1
0
Fork 0
mirror of https://github.com/delight-im/PHP-Auth.git synced 2025-08-04 15:17:28 +02:00
Code Issues Releases Wiki Activity

Write to session fields directly instead of using accessor methods

Browse Source
This commit is contained in:
Marco
2017-11-03 08:33:41 +01:00
parent 739fa7d574
commit 425cf9b6f6
1 changed files with 9 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

81
src/Auth.php
View File

@@ -484,14 +484,14 @@ final class Auth extends UserManager {
// re-generate the session ID to prevent session fixation attacks (requests a cookie to be written on the client) // re-generate the session ID to prevent session fixation attacks (requests a cookie to be written on the client)
Session::regenerate(true); Session::regenerate(true);
// save the user data in the session // save the user data in the session variables maintained by this library
$this->setLoggedIn(true); $_SESSION[self::SESSION_FIELD_LOGGED_IN] = true;
$this->setUserId($userId); $_SESSION[self::SESSION_FIELD_USER_ID] = (int) $userId;
$this->setEmail($email); $_SESSION[self::SESSION_FIELD_EMAIL] = $email;
$this->setUsername($username); $_SESSION[self::SESSION_FIELD_USERNAME] = $username;
$this->setStatus($status); $_SESSION[self::SESSION_FIELD_STATUS] = (int) $status;
$this->setRoles($roles); $_SESSION[self::SESSION_FIELD_ROLES] = (int) $roles;
$this->setRemembered($remembered); $_SESSION[self::SESSION_FIELD_REMEMBERED] = $remembered;
} }
/** /**
@@ -591,7 +591,7 @@ final class Auth extends UserManager {
// if the user has just confirmed an email address for their own account // if the user has just confirmed an email address for their own account
if ($this->getUserId() === $confirmationData['user_id']) { if ($this->getUserId() === $confirmationData['user_id']) {
// immediately update the email address in the current session as well // immediately update the email address in the current session as well
$this->setEmail($confirmationData['email']); $_SESSION[self::SESSION_FIELD_EMAIL] = $confirmationData['email'];
} }
} }
@@ -1318,15 +1318,6 @@ final class Auth extends UserManager {
} }
} }
/**
* Sets whether the user is currently logged in and updates the session
*
* @param bool $loggedIn whether the user is logged in or not
*/
private function setLoggedIn($loggedIn) {
$_SESSION[self::SESSION_FIELD_LOGGED_IN] = $loggedIn;
}
/** /**
* Returns whether the user is currently logged in by reading from the session * Returns whether the user is currently logged in by reading from the session
* *
@@ -1345,15 +1336,6 @@ final class Auth extends UserManager {
return $this->isLoggedIn(); return $this->isLoggedIn();
} }
/**
* Sets the currently signed-in user's ID and updates the session
*
* @param int $userId the user's ID
*/
private function setUserId($userId) {
$_SESSION[self::SESSION_FIELD_USER_ID] = (int) $userId;
}
/** /**
* Returns the currently signed-in user's ID by reading from the session * Returns the currently signed-in user's ID by reading from the session
* *
@@ -1377,15 +1359,6 @@ final class Auth extends UserManager {
return $this->getUserId(); return $this->getUserId();
} }
/**
* Sets the currently signed-in user's email address and updates the session
*
* @param string $email the email address
*/
private function setEmail($email) {
$_SESSION[self::SESSION_FIELD_EMAIL] = $email;
}
/** /**
* Returns the currently signed-in user's email address by reading from the session * Returns the currently signed-in user's email address by reading from the session
* *
@@ -1400,15 +1373,6 @@ final class Auth extends UserManager {
} }
} }
/**
* Sets the currently signed-in user's display name and updates the session
*
* @param string $username the display name
*/
private function setUsername($username) {
$_SESSION[self::SESSION_FIELD_USERNAME] = $username;
}
/** /**
* Returns the currently signed-in user's display name by reading from the session * Returns the currently signed-in user's display name by reading from the session
* *
@@ -1423,24 +1387,6 @@ final class Auth extends UserManager {
} }
} }
/**
* Sets the currently signed-in user's status and updates the session
*
* @param int $status the status as one of the constants from the {@see Status} class
*/
private function setStatus($status) {
$_SESSION[self::SESSION_FIELD_STATUS] = (int) $status;
}
/**
* Sets the currently signed-in user's roles and updates the session
*
* @param int $roles the bitmask containing the roles
*/
private function setRoles($roles) {
$_SESSION[self::SESSION_FIELD_ROLES] = (int) $roles;
}
/** /**
* Returns the currently signed-in user's status by reading from the session * Returns the currently signed-in user's status by reading from the session
* *
@@ -1582,15 +1528,6 @@ final class Auth extends UserManager {
return true; return true;
} }
/**
* Sets whether the currently signed-in user has been remembered by a long-lived cookie
*
* @param bool $remembered whether the user was remembered
*/
private function setRemembered($remembered) {
$_SESSION[self::SESSION_FIELD_REMEMBERED] = $remembered;
}
/** /**
* Returns whether the currently signed-in user has been remembered by a long-lived cookie * Returns whether the currently signed-in user has been remembered by a long-lived cookie
* *