diff --git a/src/Dibi/Connection.php b/src/Dibi/Connection.php index 78b926c7..7035f008 100644 --- a/src/Dibi/Connection.php +++ b/src/Dibi/Connection.php @@ -29,7 +29,7 @@ class Connection /** @var string[] resultset formats */ private array $formats; - private ?Driver $driver = null; + private ?Drivers\Connection $driver = null; private ?Translator $translator = null; /** @var array */ @@ -122,12 +122,12 @@ class Connection */ final public function connect(): void { - if ($this->config['driver'] instanceof Driver) { + if ($this->config['driver'] instanceof Drivers\Connection) { $this->driver = $this->config['driver']; $this->translator = new Translator($this); return; - } elseif (is_subclass_of($this->config['driver'], Driver::class)) { + } elseif (is_subclass_of($this->config['driver'], Drivers\Connection::class)) { $class = $this->config['driver']; } else { @@ -198,7 +198,7 @@ class Connection /** * Returns the driver and connects to a database in lazy mode. */ - final public function getDriver(): Driver + final public function getDriver(): Drivers\Connection { if (!$this->driver) { $this->connect(); @@ -450,7 +450,7 @@ class Connection /** * Result set factory. */ - public function createResultSet(ResultDriver $resultDriver): Result + public function createResultSet(Drivers\Result $resultDriver): Result { return (new Result($resultDriver, $this->config['result']['normalize'] ?? true)) ->setFormats($this->formats); diff --git a/src/Dibi/Drivers/Connection.php b/src/Dibi/Drivers/Connection.php new file mode 100644 index 00000000..9ff28e70 --- /dev/null +++ b/src/Dibi/Drivers/Connection.php @@ -0,0 +1,97 @@ + buffers is the number of database buffers to allocate for the server-side cache. If 0 or omitted, server chooses its own default. * - resource (resource) => existing connection resource */ -class FirebirdDriver implements Dibi\Driver +class FirebirdDriver implements Connection { public const ErrorExceptionThrown = -836; @@ -86,7 +86,7 @@ class FirebirdDriver implements Dibi\Driver * Executes the SQL query. * @throws Dibi\DriverException|Dibi\Exception */ - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Result { $resource = $this->inTransaction ? $this->transaction @@ -200,7 +200,7 @@ class FirebirdDriver implements Dibi\Driver /** * Returns the connection reflector. */ - public function getReflector(): Dibi\Reflector + public function getReflector(): Engine { return new FirebirdReflector($this); } diff --git a/src/Dibi/Drivers/FirebirdReflector.php b/src/Dibi/Drivers/FirebirdReflector.php index 9b23fdd3..292c800b 100644 --- a/src/Dibi/Drivers/FirebirdReflector.php +++ b/src/Dibi/Drivers/FirebirdReflector.php @@ -9,16 +9,15 @@ declare(strict_types=1); namespace Dibi\Drivers; -use Dibi; /** * The reflector for Firebird/InterBase database. */ -class FirebirdReflector implements Dibi\Reflector +class FirebirdReflector implements Engine { public function __construct( - private readonly Dibi\Driver $driver, + private readonly Connection $driver, ) { } diff --git a/src/Dibi/Drivers/FirebirdResult.php b/src/Dibi/Drivers/FirebirdResult.php index 5abc8418..6d231826 100644 --- a/src/Dibi/Drivers/FirebirdResult.php +++ b/src/Dibi/Drivers/FirebirdResult.php @@ -17,7 +17,7 @@ use function is_resource; /** * The driver for Firebird/InterBase result set. */ -class FirebirdResult implements Dibi\ResultDriver +class FirebirdResult implements Result { public function __construct( /** @var resource */ diff --git a/src/Dibi/Drivers/MySqlReflector.php b/src/Dibi/Drivers/MySqlReflector.php index 0f968a71..ecf1cfa2 100644 --- a/src/Dibi/Drivers/MySqlReflector.php +++ b/src/Dibi/Drivers/MySqlReflector.php @@ -16,10 +16,10 @@ use Dibi; * The reflector for MySQL databases. * @internal */ -class MySqlReflector implements Dibi\Reflector +class MySqlReflector implements Engine { public function __construct( - private readonly Dibi\Driver $driver, + private readonly Connection $driver, ) { } diff --git a/src/Dibi/Drivers/MySqliDriver.php b/src/Dibi/Drivers/MySqliDriver.php index a19f1697..595147dc 100644 --- a/src/Dibi/Drivers/MySqliDriver.php +++ b/src/Dibi/Drivers/MySqliDriver.php @@ -32,7 +32,7 @@ use const MYSQLI_REPORT_OFF, MYSQLI_STORE_RESULT, MYSQLI_USE_RESULT, PREG_SET_OR * - sqlmode => see http://dev.mysql.com/doc/refman/5.0/en/server-sql-mode.html * - resource (mysqli) => existing connection resource */ -class MySqliDriver implements Dibi\Driver +class MySqliDriver implements Connection { public const ErrorAccessDenied = 1045; public const ErrorDuplicateEntry = 1062; @@ -148,7 +148,7 @@ class MySqliDriver implements Dibi\Driver * Executes the SQL query. * @throws Dibi\DriverException */ - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Result { $res = @$this->connection->query($sql, $this->buffered ? MYSQLI_STORE_RESULT : MYSQLI_USE_RESULT); // intentionally @ @@ -265,7 +265,7 @@ class MySqliDriver implements Dibi\Driver /** * Returns the connection reflector. */ - public function getReflector(): Dibi\Reflector + public function getReflector(): Engine { return new MySqlReflector($this); } diff --git a/src/Dibi/Drivers/MySqliResult.php b/src/Dibi/Drivers/MySqliResult.php index 413c1d9f..50d08869 100644 --- a/src/Dibi/Drivers/MySqliResult.php +++ b/src/Dibi/Drivers/MySqliResult.php @@ -16,7 +16,7 @@ use const MYSQLI_TYPE_LONG, MYSQLI_TYPE_SHORT, MYSQLI_TYPE_TIME, MYSQLI_TYPE_TIN /** * The driver for MySQL result set. */ -class MySqliResult implements Dibi\ResultDriver +class MySqliResult implements Result { public function __construct( private readonly \mysqli_result $resultSet, diff --git a/src/Dibi/Drivers/NoDataResult.php b/src/Dibi/Drivers/NoDataResult.php index 480db598..7f5190a5 100644 --- a/src/Dibi/Drivers/NoDataResult.php +++ b/src/Dibi/Drivers/NoDataResult.php @@ -9,13 +9,12 @@ declare(strict_types=1); namespace Dibi\Drivers; -use Dibi; /** * The driver for no result set. */ -class NoDataResult implements Dibi\ResultDriver +class NoDataResult implements Result { public function __construct( private readonly int $rows, diff --git a/src/Dibi/Drivers/OdbcDriver.php b/src/Dibi/Drivers/OdbcDriver.php index 2d56db19..27b8b0a3 100644 --- a/src/Dibi/Drivers/OdbcDriver.php +++ b/src/Dibi/Drivers/OdbcDriver.php @@ -24,7 +24,7 @@ use function is_resource; * - resource (resource) => existing connection resource * - microseconds (bool) => use microseconds in datetime format? */ -class OdbcDriver implements Dibi\Driver +class OdbcDriver implements Connection { /** @var resource */ private $connection; @@ -77,7 +77,7 @@ class OdbcDriver implements Dibi\Driver * Executes the SQL query. * @throws Dibi\DriverException */ - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Result { $this->affectedRows = null; $res = @odbc_exec($this->connection, $sql); // intentionally @ @@ -176,7 +176,7 @@ class OdbcDriver implements Dibi\Driver /** * Returns the connection reflector. */ - public function getReflector(): Dibi\Reflector + public function getReflector(): Engine { return new OdbcReflector($this); } diff --git a/src/Dibi/Drivers/OdbcReflector.php b/src/Dibi/Drivers/OdbcReflector.php index 0ec04a4c..a9da505c 100644 --- a/src/Dibi/Drivers/OdbcReflector.php +++ b/src/Dibi/Drivers/OdbcReflector.php @@ -15,10 +15,10 @@ use Dibi; /** * The reflector for ODBC connections. */ -class OdbcReflector implements Dibi\Reflector +class OdbcReflector implements Engine { public function __construct( - private readonly Dibi\Driver $driver, + private readonly Connection $driver, ) { } diff --git a/src/Dibi/Drivers/OdbcResult.php b/src/Dibi/Drivers/OdbcResult.php index 42947a8f..eb839afc 100644 --- a/src/Dibi/Drivers/OdbcResult.php +++ b/src/Dibi/Drivers/OdbcResult.php @@ -16,7 +16,7 @@ use function is_resource; /** * The driver interacting with result set via ODBC connections. */ -class OdbcResult implements Dibi\ResultDriver +class OdbcResult implements Result { private int $row = 0; diff --git a/src/Dibi/Drivers/OracleDriver.php b/src/Dibi/Drivers/OracleDriver.php index 83425a3c..7c035993 100644 --- a/src/Dibi/Drivers/OracleDriver.php +++ b/src/Dibi/Drivers/OracleDriver.php @@ -26,7 +26,7 @@ use function in_array, is_resource; * - resource (resource) => existing connection resource * - persistent => Creates persistent connections with oci_pconnect instead of oci_new_connect */ -class OracleDriver implements Dibi\Driver +class OracleDriver implements Connection { /** @var resource */ private $connection; @@ -77,7 +77,7 @@ class OracleDriver implements Dibi\Driver * Executes the SQL query. * @throws Dibi\DriverException */ - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Result { $this->affectedRows = null; $res = oci_parse($this->connection, $sql); @@ -190,7 +190,7 @@ class OracleDriver implements Dibi\Driver /** * Returns the connection reflector. */ - public function getReflector(): Dibi\Reflector + public function getReflector(): Engine { return new OracleReflector($this); } diff --git a/src/Dibi/Drivers/OracleReflector.php b/src/Dibi/Drivers/OracleReflector.php index 1ab4962d..8ffa5e18 100644 --- a/src/Dibi/Drivers/OracleReflector.php +++ b/src/Dibi/Drivers/OracleReflector.php @@ -15,10 +15,10 @@ use Dibi; /** * The reflector for Oracle database. */ -class OracleReflector implements Dibi\Reflector +class OracleReflector implements Engine { public function __construct( - private readonly Dibi\Driver $driver, + private readonly Connection $driver, ) { } diff --git a/src/Dibi/Drivers/OracleResult.php b/src/Dibi/Drivers/OracleResult.php index 5cf4be19..3ef698da 100644 --- a/src/Dibi/Drivers/OracleResult.php +++ b/src/Dibi/Drivers/OracleResult.php @@ -16,7 +16,7 @@ use function is_resource; /** * The driver for Oracle result set. */ -class OracleResult implements Dibi\ResultDriver +class OracleResult implements Result { public function __construct( /** @var resource */ diff --git a/src/Dibi/Drivers/PdoDriver.php b/src/Dibi/Drivers/PdoDriver.php index aa7dc7e4..fdf29d70 100644 --- a/src/Dibi/Drivers/PdoDriver.php +++ b/src/Dibi/Drivers/PdoDriver.php @@ -25,7 +25,7 @@ use function sprintf; * - options (array) => driver specific options {@see PDO::__construct} * - resource (PDO) => existing connection */ -class PdoDriver implements Dibi\Driver +class PdoDriver implements Connection { private ?PDO $connection; private ?int $affectedRows; @@ -80,7 +80,7 @@ class PdoDriver implements Dibi\Driver * Executes the SQL query. * @throws Dibi\DriverException */ - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Result { $res = $this->connection->query($sql); if ($res) { @@ -172,7 +172,7 @@ class PdoDriver implements Dibi\Driver /** * Returns the connection reflector. */ - public function getReflector(): Dibi\Reflector + public function getReflector(): Engine { return match ($this->driverName) { 'mysql' => new MySqlReflector($this), diff --git a/src/Dibi/Drivers/PdoResult.php b/src/Dibi/Drivers/PdoResult.php index bfb0f602..1bb1673c 100644 --- a/src/Dibi/Drivers/PdoResult.php +++ b/src/Dibi/Drivers/PdoResult.php @@ -17,7 +17,7 @@ use PDO; /** * The driver for PDO result set. */ -class PdoResult implements Dibi\ResultDriver +class PdoResult implements Result { public function __construct( private ?\PDOStatement $resultSet, diff --git a/src/Dibi/Drivers/PostgreDriver.php b/src/Dibi/Drivers/PostgreDriver.php index 880762d3..4295cad5 100644 --- a/src/Dibi/Drivers/PostgreDriver.php +++ b/src/Dibi/Drivers/PostgreDriver.php @@ -27,7 +27,7 @@ use function in_array, is_array, is_resource, strlen; * - resource (PgSql\Connection) => existing connection resource * - connect_type (int) => see pg_connect() */ -class PostgreDriver implements Dibi\Driver +class PostgreDriver implements Connection { private PgSql\Connection $connection; private ?int $affectedRows; @@ -110,7 +110,7 @@ class PostgreDriver implements Dibi\Driver * Executes the SQL query. * @throws Dibi\DriverException */ - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Result { $this->affectedRows = null; $res = @pg_query($this->connection, $sql); // intentionally @ @@ -232,7 +232,7 @@ class PostgreDriver implements Dibi\Driver /** * Returns the connection reflector. */ - public function getReflector(): Dibi\Reflector + public function getReflector(): Engine { return new PostgreReflector($this); } diff --git a/src/Dibi/Drivers/PostgreReflector.php b/src/Dibi/Drivers/PostgreReflector.php index ab93130c..c16a9b63 100644 --- a/src/Dibi/Drivers/PostgreReflector.php +++ b/src/Dibi/Drivers/PostgreReflector.php @@ -9,16 +9,15 @@ declare(strict_types=1); namespace Dibi\Drivers; -use Dibi; /** * The reflector for PostgreSQL database. */ -class PostgreReflector implements Dibi\Reflector +class PostgreReflector implements Engine { public function __construct( - private readonly Dibi\Driver $driver, + private readonly Connection $driver, ) { } diff --git a/src/Dibi/Drivers/PostgreResult.php b/src/Dibi/Drivers/PostgreResult.php index 88af04e9..25eb9abf 100644 --- a/src/Dibi/Drivers/PostgreResult.php +++ b/src/Dibi/Drivers/PostgreResult.php @@ -9,7 +9,6 @@ declare(strict_types=1); namespace Dibi\Drivers; -use Dibi; use Dibi\Helpers; use PgSql; use function is_resource; @@ -18,7 +17,7 @@ use function is_resource; /** * The driver for PostgreSQL result set. */ -class PostgreResult implements Dibi\ResultDriver +class PostgreResult implements Result { public function __construct( private readonly PgSql\Result $resultSet, diff --git a/src/Dibi/Drivers/Result.php b/src/Dibi/Drivers/Result.php new file mode 100644 index 00000000..f90658b3 --- /dev/null +++ b/src/Dibi/Drivers/Result.php @@ -0,0 +1,58 @@ + how to format datetime in SQL (@see date) * - resource (SQLite3) => existing connection resource */ -class SqliteDriver implements Dibi\Driver +class SqliteDriver implements Connection { private SQLite3 $connection; private string $fmtDate; @@ -73,7 +73,7 @@ class SqliteDriver implements Dibi\Driver * Executes the SQL query. * @throws Dibi\DriverException */ - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Result { $res = @$this->connection->query($sql); // intentionally @ if ($code = $this->connection->lastErrorCode()) { @@ -174,7 +174,7 @@ class SqliteDriver implements Dibi\Driver /** * Returns the connection reflector. */ - public function getReflector(): Dibi\Reflector + public function getReflector(): Engine { return new SqliteReflector($this); } diff --git a/src/Dibi/Drivers/SqliteReflector.php b/src/Dibi/Drivers/SqliteReflector.php index 8c1e3ade..d2c449a9 100644 --- a/src/Dibi/Drivers/SqliteReflector.php +++ b/src/Dibi/Drivers/SqliteReflector.php @@ -9,16 +9,15 @@ declare(strict_types=1); namespace Dibi\Drivers; -use Dibi; /** * The reflector for SQLite database. */ -class SqliteReflector implements Dibi\Reflector +class SqliteReflector implements Engine { public function __construct( - private readonly Dibi\Driver $driver, + private readonly Connection $driver, ) { } diff --git a/src/Dibi/Drivers/SqliteResult.php b/src/Dibi/Drivers/SqliteResult.php index 0758cfe9..3715b97a 100644 --- a/src/Dibi/Drivers/SqliteResult.php +++ b/src/Dibi/Drivers/SqliteResult.php @@ -17,7 +17,7 @@ use const SQLITE3_ASSOC, SQLITE3_BLOB, SQLITE3_FLOAT, SQLITE3_INTEGER, SQLITE3_N /** * The driver for SQLite result set. */ -class SqliteResult implements Dibi\ResultDriver +class SqliteResult implements Result { public function __construct( private readonly \SQLite3Result $resultSet, diff --git a/src/Dibi/Drivers/SqlsrvDriver.php b/src/Dibi/Drivers/SqlsrvDriver.php index c786c40b..9b6bb194 100644 --- a/src/Dibi/Drivers/SqlsrvDriver.php +++ b/src/Dibi/Drivers/SqlsrvDriver.php @@ -26,7 +26,7 @@ use function is_resource, sprintf; * - charset => character encoding to set (default is UTF-8) * - resource (resource) => existing connection resource */ -class SqlsrvDriver implements Dibi\Driver +class SqlsrvDriver implements Connection { /** @var resource */ private $connection; @@ -84,7 +84,7 @@ class SqlsrvDriver implements Dibi\Driver * Executes the SQL query. * @throws Dibi\DriverException */ - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Result { $this->affectedRows = null; $res = sqlsrv_query($this->connection, $sql); @@ -171,7 +171,7 @@ class SqlsrvDriver implements Dibi\Driver /** * Returns the connection reflector. */ - public function getReflector(): Dibi\Reflector + public function getReflector(): Engine { return new SqlsrvReflector($this); } diff --git a/src/Dibi/Drivers/SqlsrvReflector.php b/src/Dibi/Drivers/SqlsrvReflector.php index 45b841cf..97be4c68 100644 --- a/src/Dibi/Drivers/SqlsrvReflector.php +++ b/src/Dibi/Drivers/SqlsrvReflector.php @@ -16,10 +16,10 @@ use function sprintf; /** * The reflector for Microsoft SQL Server and SQL Azure databases. */ -class SqlsrvReflector implements Dibi\Reflector +class SqlsrvReflector implements Engine { public function __construct( - private readonly Dibi\Driver $driver, + private readonly Connection $driver, ) { } diff --git a/src/Dibi/Drivers/SqlsrvResult.php b/src/Dibi/Drivers/SqlsrvResult.php index f2e79356..916b59e9 100644 --- a/src/Dibi/Drivers/SqlsrvResult.php +++ b/src/Dibi/Drivers/SqlsrvResult.php @@ -16,7 +16,7 @@ use function is_resource; /** * The driver for Microsoft SQL Server and SQL Azure result set. */ -class SqlsrvResult implements Dibi\ResultDriver +class SqlsrvResult implements Result { public function __construct( /** @var resource */ diff --git a/src/Dibi/Helpers.php b/src/Dibi/Helpers.php index 6db7b167..e143623e 100644 --- a/src/Dibi/Helpers.php +++ b/src/Dibi/Helpers.php @@ -159,7 +159,7 @@ class Helpers /** @internal */ - public static function escape(Driver $driver, $value, string $type): string + public static function escape(Drivers\Connection $driver, $value, string $type): string { $types = [ Type::Text => 'text', diff --git a/src/Dibi/IDataSource.php b/src/Dibi/IDataSource.php new file mode 100644 index 00000000..0565fc45 --- /dev/null +++ b/src/Dibi/IDataSource.php @@ -0,0 +1,20 @@ +columns)) { $this->columns = []; - $reflector = $this->driver instanceof Dibi\Reflector + $reflector = $this->driver instanceof Dibi\Drivers\Engine ? $this->driver : null; foreach ($this->driver->getResultColumns() as $info) { diff --git a/src/Dibi/Reflection/Table.php b/src/Dibi/Reflection/Table.php index d4cbe0d4..986a59bf 100644 --- a/src/Dibi/Reflection/Table.php +++ b/src/Dibi/Reflection/Table.php @@ -26,7 +26,7 @@ use function array_values, strtolower; */ class Table { - private readonly Dibi\Reflector $reflector; + private readonly Dibi\Drivers\Engine $reflector; private string $name; private bool $view; @@ -41,7 +41,7 @@ class Table private ?Index $primaryKey; - public function __construct(Dibi\Reflector $reflector, array $info) + public function __construct(Dibi\Drivers\Engine $reflector, array $info) { $this->reflector = $reflector; $this->name = $info['name']; diff --git a/src/Dibi/Result.php b/src/Dibi/Result.php index 77de8b1b..b45faf91 100644 --- a/src/Dibi/Result.php +++ b/src/Dibi/Result.php @@ -20,7 +20,7 @@ use const PREG_SPLIT_DELIM_CAPTURE, PREG_SPLIT_NO_EMPTY; */ class Result implements IDataSource { - private ?ResultDriver $driver; + private ?Drivers\Result $driver; /** Translate table */ private array $types = []; @@ -37,7 +37,7 @@ class Result implements IDataSource private array $formats = []; - public function __construct(ResultDriver $driver, bool $normalize = true) + public function __construct(Drivers\Result $driver, bool $normalize = true) { $this->driver = $driver; if ($normalize) { @@ -62,7 +62,7 @@ class Result implements IDataSource * Safe access to property $driver. * @throws \RuntimeException */ - final public function getResultDriver(): ResultDriver + final public function getResultDriver(): Drivers\Result { if ($this->driver === null) { throw new \RuntimeException('Result-set was released from memory.'); diff --git a/src/Dibi/Translator.php b/src/Dibi/Translator.php index cb9a80db..58b9bb4c 100644 --- a/src/Dibi/Translator.php +++ b/src/Dibi/Translator.php @@ -17,8 +17,8 @@ use function array_filter, array_keys, array_splice, array_values, count, explod */ final class Translator { - private readonly Connection $connection; - private readonly Driver $driver; + private Connection $connection; + private readonly Drivers\Connection $driver; private int $cursor = 0; private array $args; diff --git a/src/Dibi/interfaces.php b/src/Dibi/interfaces.php deleted file mode 100644 index 753d0b6e..00000000 --- a/src/Dibi/interfaces.php +++ /dev/null @@ -1,180 +0,0 @@ -getConfig('lazy')); Assert::same($config['driver'], $conn->getConfig('driver')); - Assert::type(Dibi\Driver::class, $conn->getDriver()); + Assert::type(Dibi\Drivers\Connection::class, $conn->getDriver()); }); diff --git a/tests/dibi/Fluent.fetch.limit.mssql.phpt b/tests/dibi/Fluent.fetch.limit.mssql.phpt index d07ce4e8..cc358042 100644 --- a/tests/dibi/Fluent.fetch.limit.mssql.phpt +++ b/tests/dibi/Fluent.fetch.limit.mssql.phpt @@ -19,7 +19,7 @@ class MockDriver extends Dibi\Drivers\SqlsrvDriver } - public function query(string $sql): ?Dibi\ResultDriver + public function query(string $sql): ?Dibi\Drivers\Result { return new MockResult; }