mirror/php-e107
1
0
Fork 0
mirror of https://github.com/e107inc/e107.git synced 2025-08-12 09:34:54 +02:00
Code Issues Releases Wiki Activity

Login flow consistency: Do not use redirect in admin area login box

Browse Source 
The non-admin login flow does not perform a redirect, but the admin
login flow did. This led to an inconsistency in how the authentication
error message was passed.

Fixes: https://github.com/e107inc/e107/issues/4779
This commit is contained in:
Nick Liu
2022-09-07 12:32:02 -05:00
parent b95712578a
commit 00b1d754b0
3 changed files with 23 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
e107_tests/tests/acceptance/0001_AdminLoginCest.php
View File

@@ -11,7 +11,19 @@ class AdminLoginCest
{
}
// tests
/**
* @see https://github.com/e107inc/e107/issues/4779
*/
public function testAdminFailedLogin(AcceptanceTester $I)
{
$I->wantTo("See a login failure message in the admin area if I put in the wrong credentials");
$I->amOnPage("/e107_admin/admin.php");
$I->fillField('authname', 'e107');
$I->fillField('authpass', 'wrong password');
$I->click('authsubmit');
$I->see("Your login details don't match any registered user");
}
public function testAdminLogin(AcceptanceTester $I)
{
@@ -27,7 +39,6 @@ class AdminLoginCest
}
private function e107Login(AcceptanceTester $I)
{
$I->amOnPage('/e107_admin/admin.php');