mirror/php-e107
1
0
Fork 0
mirror of https://github.com/e107inc/e107.git synced 2025-08-14 18:44:27 +02:00
Code Issues Releases Wiki Activity

Moved the "in admin area" check into its own method. Added a test for it. Removed the outdated user/usersettings check.

Browse Source
This commit is contained in:
Cameron
2020-12-27 11:25:48 -08:00
parent 51df14c054
commit 026415b476
2 changed files with 73 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
e107_tests/tests/unit/e107Test.php
View File

@@ -950,6 +950,41 @@ class e107Test extends \Codeception\Test\Unit
}
public function testInAdminDir()
{
$tests = array(
0 => array('path' => 'thumb.php', 'plugdir' => false, 'expected' => false),
1 => array('path' => 'index.php', 'plugdir' => false, 'expected' => false),
2 => array('path' => 'e107_admin/prefs.php', 'plugdir' => false, 'expected' => true),
3 => array('path' => 'e107_admin/menus.php', 'plugdir' => false, 'expected' => true),
4 => array('path' => 'e107_plugins/forum/forum.php', 'plugdir' => true, 'expected' => false),
5 => array('path' => 'e107_plugins/vstore/admin_config.php', 'plugdir' => true, 'expected' => true),
6 => array('path' => 'e107_plugins/login_menu/config.php', 'plugdir' => true, 'expected' => true),
7 => array('path' => 'e107_plugins/aplugin/prefs.php', 'plugdir' => true, 'expected' => true),
8 => array('path' => 'e107_plugins/dtree_menu/dtree_config.php', 'plugdir' => true, 'expected' => true),
);
foreach($tests as $var)
{
$curPage = basename($var['path']);
$result = $this->e107->inAdminDir($var['path'], $curPage, $var['plugdir']);
$this->assertSame($var['expected'], $result);
}
// Test legacy override.
$GLOBALS['eplug_admin'] = true;
$result = $this->e107->inAdminDir('myplugin.php','myplugin.php', true);
$this->assertTrue($result);
// Test legacy off.
$GLOBALS['eplug_admin'] = false;
$result = $this->e107->inAdminDir('myplugin.php','myplugin.php', true);
$this->assertFalse($result);
}
public function testFilter_request()
{