1
0
mirror of https://github.com/e107inc/e107.git synced 2025-08-26 07:44:49 +02:00

Improved detection of deprecated functions/methods and display in DEBUG mode: deprecated.

This commit is contained in:
Cameron
2020-12-21 10:00:28 -08:00
parent 63527c4f19
commit 630f3f415f
30 changed files with 224 additions and 82 deletions

View File

@@ -26,6 +26,8 @@ class comment_menu_shortcodes extends e_shortcode
*/
function sc_cm_icon()
{
trigger_error('<b>'.__METHOD__.' is deprecated.</b>', E_USER_DEPRECATED); // NO LAN
//TODO review bullet
$bullet = '';
if(defined('BULLET'))

View File

@@ -638,18 +638,22 @@ class download_shortcodes extends e_shortcode
}
/**
* @Deprecated DOWNLOAD_VIEW_DATE should be used instead.
* @deprecated DOWNLOAD_VIEW_DATE should be used instead.
*/
function sc_download_view_date_short()
{
return $this->sc_download_view_date('short');
trigger_error('<b>{DOWNLOAD_VIEW_DATE_SHORT} is deprecated.</b> Use {DOWNLOAD_VIEW_DATE} instead.', E_USER_DEPRECATED); // NO LAN
return $this->sc_download_view_date('short');
}
/**
* @Deprecated DOWNLOAD_VIEW_DATE should be used instead.
* @deprecated DOWNLOAD_VIEW_DATE should be used instead.
*/
function sc_download_view_date_long()
{
trigger_error('<b>{DOWNLOAD_VIEW_DATE_LONG} is deprecated.</b> Use {DOWNLOAD_VIEW_DATE} instead.', E_USER_DEPRECATED); // NO LAN
return $this->sc_download_view_date('long');
}

View File

@@ -140,6 +140,8 @@ e107::getLanguage()->bcDefs($bcDefs);
*/
function sc_lm_imagecode($parm='')
{
trigger_error('<b>{LM_IMAGECODE} is deprecated.</b> Use {LM_IMAGECODE_NUMBER}, {LM_IMAGECODE_BOX} instead.', E_USER_DEPRECATED); // NO LAN
//DEPRECATED - use LM_IMAGECODE_NUMBER, LM_IMAGECODE_BOX instead
if($this->use_imagecode)
{

View File

@@ -142,6 +142,7 @@
*/
function show_send($to_uid)
{
// trigger_error('Method ' . __METHOD__ . ' is deprecated. Use e107::serialize() instead.', E_USER_DEPRECATED);
$pm_info = array();
$pm_outbox = $this->pmManager->pm_getInfo('outbox');

View File

@@ -111,6 +111,7 @@ class private_message
*/
function add($vars)
{
$tp = e107::getParser();
$sql = e107::getDb();
$pmsize = 0;
@@ -200,7 +201,7 @@ class private_message
$totalSend = count($tolist);
$targets = array_chunk($tolist, $maxSendNow); // Split into a number of lists, each with the maximum number of elements (apart from the last block, of course)
unset($tolist);
$array = new ArrayData;
$pmInfo = $info;
$genInfo = array(
'gen_type' => 'pm_bulk',
@@ -212,7 +213,7 @@ class private_message
{ // Save the list in the 'generic' table
$pmInfo['to_array'] = $targets[$i]; // Should be in exactly the right format
$genInfo['gen_intdata'] = count($targets[$i]);
$genInfo['gen_chardata'] = $array->WriteArray($pmInfo,TRUE);
$genInfo['gen_chardata'] = e107::serialize($pmInfo,TRUE);
$sql->insert('generic', array('data' => $genInfo, '_FIELD_TYPES' => array('gen_chardata' => 'string'))); // Don't want any of the clever sanitising now
}
$toclass .= ' ['.$totalSend.']';