From 645e162253d517cd7ae767a5fdc8072196adc16b Mon Sep 17 00:00:00 2001
From: Nick Liu <deltik@gmx.com>
Date: Sat, 28 Nov 2020 17:08:36 +0100
Subject: [PATCH] Reduce NPath complexity in plugin_forum_viewforum_shortcodes

Method plugin_forum_viewforum_shortcodes::sc_newthreadbuttonx()
---
 .../shortcodes/batch/viewforum_shortcodes.php | 22 ++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/e107_plugins/forum/shortcodes/batch/viewforum_shortcodes.php b/e107_plugins/forum/shortcodes/batch/viewforum_shortcodes.php
index b2ee09f1f..11f0b2d90 100644
--- a/e107_plugins/forum/shortcodes/batch/viewforum_shortcodes.php
+++ b/e107_plugins/forum/shortcodes/batch/viewforum_shortcodes.php
@@ -96,12 +96,24 @@
 		    	<ul class="dropdown-menu pull-right">
 		    	';
 */
+			$href = "#";
+			$disabled = " disabled";
+			$restricted_to_members_only = " data-toggle='tooltip' title='".LAN_FORUM_0006."'
+			style='cursor: not-allowed; pointer-events: all !important;'";
+			$extra_space = "<span>&nbsp;</span>";
+			if ($this->var['ntUrl'])
+			{
+				$href = $this->var['ntUrl'];
+				$disabled = "";
+				$restricted_to_members_only = "";
+				$extra_space = "";
+			}
+
 			$text .=
-			'<a href="'.($this->var['ntUrl'] ?:"#").
-			'" class="btn btn-primary'.($this->var['ntUrl'] ?"":" disabled").'"'
-			.($this->var['ntUrl'] ?"":" data-toggle='tooltip' title='".LAN_FORUM_0006."'
-			style='cursor: not-allowed; pointer-events: all !important;'").'>'.LAN_FORUM_1018.'</a>
-			'.($this->var['ntUrl'] ?"":"<span>&nbsp;</span>").'
+			'<a href="'.$href.
+			'" class="btn btn-primary'.$disabled.'"'
+			.$restricted_to_members_only.'>'.LAN_FORUM_1018.'</a>
+			'.$extra_space.'
 			<button class="btn btn-primary dropdown-toggle" data-toggle="dropdown">
 			';
 			if($bootstrap !== 4)