mirror/php-e107
1
0
Fork 0
mirror of https://github.com/e107inc/e107.git synced 2025-08-01 20:30:39 +02:00
Code Issues Releases Wiki Activity

Extra performance in e_file_inspector_json

Browse Source 
Squeezed out more performance at the cost of memory usage
This commit is contained in:
Nick Liu
2020-03-23 18:15:15 -05:00
parent b8ed70693f
commit 76bb9f6ad8
1 changed files with 3 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
e107_handlers/e_file_inspector_json.php
View File

@@ -21,7 +21,7 @@ class e_file_inspector_json extends e_file_inspector
global $core_image; global $core_image;
if ($jsonFilePath === null) $jsonFilePath = e_ADMIN . "core_image.php"; if ($jsonFilePath === null) $jsonFilePath = e_ADMIN . "core_image.php";
require($jsonFilePath); require($jsonFilePath);
$this->coreImage = json_decode($core_image, true); $this->coreImage = self::array_slash(json_decode($core_image, true));
unset($core_image); unset($core_image);
} }
@@ -30,7 +30,7 @@ class e_file_inspector_json extends e_file_inspector
*/ */
public function getPathIterator($version = null) public function getPathIterator($version = null)
{ {
$result = self::array_slash($this->coreImage); $result = $this->coreImage;
if (!empty($version)) if (!empty($version))
{ {
$result = array_filter($result, function ($value) use ($version) $result = array_filter($result, function ($value) use ($version)
@@ -47,38 +47,7 @@ class e_file_inspector_json extends e_file_inspector
public function getChecksums($path) public function getChecksums($path)
{ {
$path = $this->pathToDefaultPath($path); $path = $this->pathToDefaultPath($path);
return self::array_get($this->coreImage, $path, []); return isset($this->coreImage[$path]) ? $this->coreImage[$path] : [];
}
/**
* Get an item from an array using "slash" notation.
*
* Based on Illuminate\Support\Arr::get()
*
* @param array $array
* @param string $key
* @param mixed $default
* @return mixed
* @copyright Copyright (c) Taylor Otwell
* @license https://github.com/illuminate/support/blob/master/LICENSE.md MIT License
*/
private static function array_get($array, $key, $default = null)
{
if (is_null($key)) return $array;
if (isset($array[$key])) return $array[$key];
foreach (explode('/', $key) as $segment)
{
if (!is_array($array) || !array_key_exists($segment, $array))
{
return $default;
}
$array = $array[$segment];
}
return $array;
} }
/** /**