From 771fc01a9cb02fd94ca4d284498b50dda61bd246 Mon Sep 17 00:00:00 2001
From: berckoff <berkoff@github>
Date: Tue, 10 Jan 2012 14:40:09 +0000
Subject: [PATCH] Forum fix: fixed forgotten "global $menu_pref;" in
 newforumposts_menu.php handles improperly  the menu + fixed forgotten closing
 ">" bracket in newforumposts_menu_config.php breaks HTML and optional parsing
 titles;

---
 e107_plugins/forum/newforumposts_menu.php        | 6 ++++--
 e107_plugins/forum/newforumposts_menu_config.php | 9 ++-------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/e107_plugins/forum/newforumposts_menu.php b/e107_plugins/forum/newforumposts_menu.php
index 5191062ad..7d7541677 100755
--- a/e107_plugins/forum/newforumposts_menu.php
+++ b/e107_plugins/forum/newforumposts_menu.php
@@ -12,7 +12,9 @@
  * $Id$
  */
 
-if (!defined('e107_INIT')) { exit; }
+if (!defined('e107_INIT'))  exit;
+
+global $menu_pref;
 
 $e107 = e107::getInstance();
 $gen = new convert;
@@ -20,7 +22,7 @@ $gen = new convert;
 include_lan(e_PLUGIN.'forum/languages/'.e_LANGUAGE.'/lan_newforumposts_menu.php');
 include_once(e_PLUGIN.'forum/forum_class.php');
 
-$max_age = varset($menu_pref['newforumposts_maxage'], 0);
+$max_age = vartrue($menu_pref['newforumposts_maxage'], 0);
 $max_age = $max_age == 0 ? '' : '(t.post_datestamp > '.(time()-(int)$max_age*86400).') AND ';
 
 $forum = new e107forum;
diff --git a/e107_plugins/forum/newforumposts_menu_config.php b/e107_plugins/forum/newforumposts_menu_config.php
index a67f084e8..7ce9ba9c5 100755
--- a/e107_plugins/forum/newforumposts_menu_config.php
+++ b/e107_plugins/forum/newforumposts_menu_config.php
@@ -88,11 +88,7 @@ $text = "<div style='text-align:center'>
 	<tr>
 	<td class='forumheader3'>".NFP_8.":</td>
 	<td class='forumheader3'>
-	<input type=\"checkbox\" name=\"newforumposts_title\" value=\"1\" ";
-if ($menu_pref['newforumposts_title']) {
-	$text .= " checked ";
-}
-$text .= "
+	<input type='checkbox' name='newforumposts_title' value='1'".($menu_pref['newforumposts_title'] ? ' checked="checked"' : '')."
 	</td>
 	</tr>
 	 
@@ -105,5 +101,4 @@ $text .= "
 	</form>
 	</div>";
 $ns->tablerender(NFP_10, $text);
-require_once(e_ADMIN."footer.php");
-?>
\ No newline at end of file
+require_once(e_ADMIN."footer.php");
\ No newline at end of file