From 7c2b4f8f25040986cc2d3d91a8d27c79c9db6b91 Mon Sep 17 00:00:00 2001 From: Nick Liu Date: Fri, 2 Nov 2018 12:49:24 -0500 Subject: [PATCH] Reload e_shortcode_parser for pluginsTest::testBanner() e_shortcode_parser normally doesn't need reloading in an e107 installation because installing the "banner" plugin and parsing shortcodes have always been two separate script calls (page loads). It would slow down the e107 core to add an e_shortcode_parser reloader after installing a plugin when the page would later exit without parsing any shortcodes. --- tests/unit/pluginsTest.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/unit/pluginsTest.php b/tests/unit/pluginsTest.php index 347c69c14..8fb5b4912 100644 --- a/tests/unit/pluginsTest.php +++ b/tests/unit/pluginsTest.php @@ -123,6 +123,11 @@ $this->pluginInstall('banner'); + // App needs e_parse_shortcode to be reloaded because another test + // could have initialized e_parse_shortcode already before the + // "banner" plugin was installed. + e107::getScParser()->__construct(); + $tp = e107::getParser(); $result = $tp->parseTemplate("{BANNER=e107promo}",true); @@ -348,8 +353,8 @@ $id = 912; // No-follow plugin on e107.org $this->assertFalse(is_dir(e_PLUGIN."nofollow"), "Plugin nofollow exists before download"); - $mp->download($id, '', 'plugin'); + $this->assertTrue(is_dir(e_PLUGIN."nofollow"), "Plugin nofollow is missing after download"); $this->pluginInstall('nofollow');