1
0
mirror of https://github.com/e107inc/e107.git synced 2025-08-19 04:41:53 +02:00

36 Commits

Author SHA1 Message Date
Cameron
73dfbf0d74 Issue #4299 - PHP8 fatal error fixes 2021-10-17 08:43:07 -07:00
Nick Liu
f6d6d1b185 Deprecate e_parse::toJS()
`e_parse::toJS()`, documented with the description

> Convert text blocks which are to be embedded within JS

, does not protect strings from injections, which appears to be its
primary use.  Additionally, it performs multiple unrelated string
modifications:

* Replace Windows line breaks with a literal `\\n` (which would later be
  parsed as `\n` in JavaScript/JSON)
* Does not modify Unix line breaks (`\n`), which is inconsistent with
  the Windows line break behavior
* Removes HTML tags
* Replaces HTML entities as `htmlentities()` does

This method cannot be fixed because its usages are inconsistent.  Most
notably, some usages surround the method's output in single quotes while
others surround it with double quotes.  Strings cannot be JSON-encoded
without confounding quotation mark styles.

All core usages of `e_parse::toJS()` have been replaced with
alternatives, which are also documented in the method's DocBlock.

Fixes: #4546
2021-08-31 00:11:14 +02:00
Cameron
9890615761 Admin menu icons for collapsed menu. 2021-02-01 18:18:30 -08:00
Cameron
f055b49d91 PHP8 Plugin code cleanup 2021-01-21 09:38:38 -08:00
Cameron
402d1f4126 Closes #1801 Code cleanup. Deprecated method errors added. 2020-12-22 14:48:28 -08:00
Cameron
f5153bf640 Updating of deprecated method usage. Removal of old files. Log tests added. 2020-12-18 09:39:02 -08:00
Cameron
e1593de8ee Removed redundant PHP closing tags. 2020-08-10 15:49:44 -07:00
Cameron
b40b1916a3 Issue #2970 btn-default > btn-default btn-secondary 2018-01-10 15:06:40 -08:00
Cameron
cdc23fb2d7 Admin-area navigation 2017-02-01 18:25:32 -08:00
Cameron
43d0211590 Code cleanup: deprecated include_lan() 2017-01-23 09:41:23 -08:00
MikeyGMT
2c68d9ee52 Text to LANS #6 - Polls
Text to LANS #6 - Polls
2017-01-01 12:04:29 +00:00
Cameron
796f5fa95c Header location cleanup. From now, please use e107::redirect(); to redirect to the home page, or e107::redirect('admin'); to redirect to the admin start page or e107::redirect($url); 2016-01-13 19:18:12 -08:00
Cameron
a3514ca716 Plugin/Theme modal fixes and improved commercial plugin/theme handling. 2015-07-17 23:09:36 -07:00
Moc
fef68b788c #1058 - Also show forum polls in poll plugin admin (needs admin UI rewrite) 2015-06-17 15:42:15 +02:00
Cameron
fbb0b63ae9 replaced calls to deprecated plugInstalled() with e107::isInstalled() 2015-02-07 13:38:29 -08:00
Cameron
bb76398ac1 Fixes #501 - restored delete_32.png and delete_16.png for Backward compatibility. Updated some scripts to use ADMIN_DELETE_ICON instead of the deprecated ADMIN_DELETE_ICON_PATH . 2014-01-23 04:38:48 -08:00
Moc
81aa6032d6 Poll plugin code clean-up 2013-03-31 11:52:27 +02:00
Cameron
392b386967 Poll and Forum GUI tweaks 2013-03-29 03:59:03 -07:00
Cameron
98b8953492 GUI Fixes 2013-03-15 19:25:41 -07:00
Tijn Kuyper
adc98596c2 Various clean-up (#6, #125, 90). Removal of message and form handler. Headers updated. 2013-02-27 17:18:33 +01:00
Tijn Kuyper
d6825155ea Poll Plugin - Minor GUI changes (#90). More LAN work needed 2013-02-08 15:40:03 +01:00
Cameron
5e84eaf34d More admin GUI refinements 2012-11-26 15:43:42 -08:00
secretr
4fecfffddd svn keywords added (v0.8) 2010-02-10 18:18:01 +00:00
marj
93933d1d74 typo 2009-11-19 16:03:16 +00:00
CaMer0n
1377b23532 Fix copyright info. 2009-11-18 01:06:08 +00:00
marj
363aa0ea4d more work on charset and badchars 2009-11-17 10:46:35 +00:00
secretr
7edd4ba390 admin UI - introducing textarea auto-height, bugfixes, e-column trigger overall fix 2009-11-09 16:54:30 +00:00
CaMer0n
b9d3cf0142 Poll interface cleanup and TinyMce pref fixes 2009-09-22 18:28:49 +00:00
CaMer0n
62d5c8b49c Some CSS standardization. 2009-07-10 14:25:23 +00:00
e107steved
9af14eaf19 Admin logging, plugin.xml for chatbox. Other tidying up 2008-12-11 21:13:48 +00:00
e107steved
53880f8002 Add admin logging to poll 2008-08-17 11:54:40 +00:00
e107steved
02d542060c Convert poll plugin to plugin.xml 2008-08-16 16:25:45 +00:00
e107steved
d731eb31c5 Bugtracker #4162 - allow guests to vote in poll 2007-11-01 22:47:27 +00:00
e107steved
1c40aef215 Poll permissions are 'plugin' related 2007-10-28 21:10:00 +00:00
e107steved
fab4a3bc10 Make calls to toHTML which use $modifiers consistent to avoid potential future problems. 2007-01-07 15:59:42 +00:00
mcfly
e149b35fcc new module creation 2006-12-02 04:36:16 +00:00