\Helper\Unit::_beforeSuite() now sets E107_DEBUG_LEVEL so that
debug_handler.php sets the debug mode.
Also fixed E_NOTICE if E107_DEBUG_LEVEL is set beforehand
error_handler now only runs set_error_handler in web mode.
E_ALL notices, warnings, and errors are now reported, which causes
the test harness to fail.
Fixes: #4054
This is a better fix for #4054. HTML code injection can no longer occur in URLs generated by
e107::url() thanks to htmlspecialchars(). The previous implementation only addressed:
& => &
Now, quotation marks and alligator brackets are also escaped, so:
<a href=""></html>"></a>
is now rendered as:
<a href=""></html>"></a>
- FIX: e107::url() now puts "&" in the query string instead of "&" for compliance with the older,
looser definition of ambiguous ampersands in the HTML specification.
Fixes: #4054
- FIX: Typo in comment
- FIX: Clear the core/e107/addons/e_url registry (cache) because if a plugin is installed after that
cache is initialized, the cache is not updated anymore. The plugin's e_url is therefore not
loaded, so SEF URLs won't be generated for that plugin until the cache is regenerated.
- NEW: Test for #4054
- FIX: e_pluginTest::testGetFields() expects the initial condition of the "forum" plugin to be
uninstalled.
Apparently, there's no easy way to submit coverage reports from GitHub pull request builds
without exposing this reporter ID. Coverage diff reports should now come in from pull
request builds after this commit. The expectation is that Code Climate will comment on the
pull requests and mark the build as failed or succeeded based on the coverage diff.
This commit also disables sending code coverage reports to Codecov, which has been broken
for a while now: https://github.com/codecov/codecov-action/issues/43
Fixes test run cleanup errors that look like:
In ErrorHandler.php line 83:
rmdir(W:\www\e107v2/e107_system/000000test/): Directory not empty
Or:
In E107Preparer.php line 27:
E107Preparer couldn't delete W:\www\e107v2/e107_system/000000test
GitHub Actions actions/checkout@v1 checked out code as a detached HEAD,
which caused Code Climate test coverage reports to appear as on the HEAD branch.
Coverage reports should now appear on an upstream branch.
From the actions/checkout@v2 release notes: https://github.com/actions/checkout/blob/v2/README.md
> - Creates a local branch
> - No longer detached HEAD when checking out a branch
> - A local branch is created with the corresponding upstream branch set
- NEW: Logo at the top
- MOD: Moved Gitter badge to the end
- MOD: Added e107 logo to GitHub release badge
- MOD: Replaced GitHub Workflow badge with Shields.io equivalent for consistency
- MOD: Replaced Codecov code coverage badge with Code Climate equivalent
- MOD: Added Gitter logo and styling to Gitter badge
Increased possible random strings for unique fields in e_db_pdo::copyRow() from 1000 to 59^11 (UserHandler::generateRandomString() "alphanumeric" should have 59 characters to choose from)
If a collision still happens, e_db_pdo::copyRow() retries up to 3 times for a successful copy.
Fixes: #3678
- MOD: PHPDoc for e_file::unzipGithubArchive()
- NEW: e_file::unzipGithubArchive(): Added exclusions for files that don't exist in production
- NEW: e_file::unzipGithubArchive(): Accept a destination path argument for a custom extraction location
- NEW: Restored unimplemented skipped list in e_file::unzipGithubArchive()
- FIX: e_file::unzipGithubArchive(): Extraction fails if parent directory of file doesn't exist
- MOD: Type hint for Base::$deployer
- NEW: Basic test for e_file::unzipGithubArchive()
- MOD: Removed hard-coded version number
- NEW: Added badge for latest version number
- NEW: Added badge for build results
- NEW: Added badge for code coverage
- NEW: Added table of contents
- FIX: Clarification of system requirements
- MOD: Combined installation insructions into "Installation" secion
- MOD: Standard installation instructions now explain how to download e107
- FIX: Clarification of Git installation instructions
- FIX: Grammar in "Reporting Bugs" section
- MOD: Renamed "Pull-Requests" section to "Contributing to Development"
- FIX: Readability of the "Contributing to Development" section
- FIX: Grammar in "Donations" section
- MOD: Replaced all HTTP links with HTTPS
