1
0
mirror of https://github.com/e107inc/e107.git synced 2025-03-19 20:09:47 +01:00

12328 Commits

Author SHA1 Message Date
Cameron
2a6e3a182d Issue - Removed Admin Nav button labels for all device and provided solution for plugins to add them back via css if required. Example added to admin_style.css 2019-12-31 11:24:14 -08:00
Nick Liu
0b269013c1
Added an issue template for questions 2019-12-30 15:07:58 +01:00
Nick Liu
d31f4cd45e
E107Preparer: Clean up hidden files as well
Fixes test run cleanup errors that look like:

    In ErrorHandler.php line 83:

      rmdir(W:\www\e107v2/e107_system/000000test/): Directory not empty

Or:

    In E107Preparer.php line 27:

      E107Preparer couldn't delete W:\www\e107v2/e107_system/000000test
2019-12-30 11:15:43 +01:00
Cameron
8270c5cf42 Remove tests folder when doing a core github pull, unless developer mode is active. 2019-12-29 12:45:35 -08:00
Cameron
b26c0abfbb
Merge pull request from e107inc/fix-4052
Fixes  Use canonical file system paths in e_fileTest::testUnzipGithubArchive()
2019-12-29 12:18:40 -08:00
Nick Liu
80b49a5d14
Fix outdated Git on Debian stretch
by enabling Debian backports
2019-12-29 13:47:03 +01:00
Nick Liu
d7e083b59a
Fix Code Climate test coverage reports on wrong branch
GitHub Actions actions/checkout@v1 checked out code as a detached HEAD,
which caused Code Climate test coverage reports to appear as on the HEAD branch.

Coverage reports should now appear on an upstream branch.

From the actions/checkout@v2 release notes: https://github.com/actions/checkout/blob/v2/README.md

> - Creates a local branch
>   - No longer detached HEAD when checking out a branch
>   - A local branch is created with the corresponding upstream branch set
2019-12-29 13:20:35 +01:00
Nick Liu
029f4883e6
Use canonical file system paths in e_fileTest::testUnzipGithubArchive()
Should fix the tests on Windows

Fixes: 
2019-12-29 12:29:27 +01:00
Nick L
0f749d7822 More descriptive issue templates
Hopefully improves the reproducibility of bug reports and quality of feature requests
2019-12-29 12:08:56 +01:00
Cameron
d7451bdd3c
Merge pull request from Jimmi08/patch-4
Fixes  outdated db methods
2019-12-28 12:03:38 -08:00
Cameron
ec2061e880
Merge pull request from Jimmi08/patch-5
Fixes  blank page because missing method name
2019-12-28 12:03:09 -08:00
Cameron
b5f2cf2f9e
Merge pull request from Jimmi08/patch-2
Fixes  Missing scenario with secondary source
2019-12-28 12:02:33 -08:00
Cameron
7e5b104f7e
Merge pull request from Jimmi08/patch-1
Fixes  fatal error because non supported mysql function
2019-12-28 12:01:47 -08:00
Cameron
bcab5172e6
Merge pull request from Jimmi08/patch-3
 fix for wrong user data while creating user
2019-12-28 11:59:21 -08:00
Cameron
363eb6751a
Merge pull request from sudakk/sudakk-patch-2
Update cpage.php to prevent empty records.
2019-12-28 11:55:46 -08:00
Cameron
598522e603
Merge pull request from e107inc/test-harness
Automated Testing for e107
2019-12-28 10:45:11 -08:00
Nick Liu
8d5d184ab2
Redesigned README.md above-the-fold content
- NEW: Logo at the top
- MOD: Moved Gitter badge to the end
- MOD: Added e107 logo to GitHub release badge
- MOD: Replaced GitHub Workflow badge with Shields.io equivalent for consistency
- MOD: Replaced Codecov code coverage badge with Code Climate equivalent
- MOD: Added Gitter logo and styling to Gitter badge
2019-12-28 18:23:13 +01:00
Nick Liu
939d01271c
GitHub Actions: Upload code coverage report to Code Climate as well 2019-12-28 16:57:30 +01:00
Nick Liu
4ca73daad5
Salt state e107-dev now installs LAMP for acceptance tests 2019-12-28 15:39:21 +01:00
Nick Liu
20ed1ecb00
Enable xdebug in PHP 5.6 builds 2019-12-28 10:58:07 +01:00
Nick Liu
60aa3f34d4
Refactored e_db_pdo::copyRow() for Codeception
Fixes: "The method copyRow() has an NPath complexity of 252. The configured NPath complexity threshold is 200."
2019-12-28 10:57:51 +01:00
Nick Liu
c31b645013
Made acceptance tests work again
Broken due to Codeception moving modules out of codeception/codeception
2019-12-28 10:35:36 +01:00
Nick Liu
e797efce74
Fixed some formatting oddities 2019-12-27 22:18:27 +01:00
Nick Liu
fabb0c2757
e_db_pdo::copyRow() - Greatly decrease collision chance
Increased possible random strings for unique fields in e_db_pdo::copyRow() from 1000 to 59^11 (UserHandler::generateRandomString() "alphanumeric" should have 59 characters to choose from)

If a collision still happens, e_db_pdo::copyRow() retries up to 3 times for a successful copy.

Fixes: 
2019-12-27 21:54:11 +01:00
Nick Liu
5e9b3bee14
Resolve Code Climate error about file not existing
Error message from Code Climate:

> Exception: The given file "/code/e107_tests/lib/ci/salt/pillars/config-local.sls" does not exist. in /usr/src/app/vendor/pdepend/pdepend/src/main/php/PDepend/Engine.php
>  /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(129): PDepend\Engine->addFile('/code/e107_test...')
>  /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(109): PHPMD\ParserFactory->initInput(Object(PDepend\Engine), Object(PHPMD\PHPMD))
>  /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(76): PHPMD\ParserFactory->init(Object(PDepend\Engine), Object(PHPMD\PHPMD))
>  /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/PHPMD.php(215): PHPMD\ParserFactory->create(Object(PHPMD\PHPMD))
>  /usr/src/app/Runner.php(116): PHPMD\PHPMD->processFiles('/code/e107_test...', 'cleancode,unuse...', Array, Object(PHPMD\RuleSetFactory))
>  /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1852): CodeClimate\PHPMD\Runner->run(Array)
>  /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1772): fork_daemon->invoke_callback(Array, Array, false)
>  /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1673): fork_daemon->fork_work_unit(Array, '', -1)
>  /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1445): fork_daemon->process_work_unit(-1)
>  /usr/src/app/Runner.php(31): fork_daemon->process_work(false)
>  /usr/src/app/engine.php(35): CodeClimate\PHPMD\Runner->queueDirectory('/code')
>  {main}
2019-12-27 19:35:19 +01:00
Nick Liu
3b4240bbae
Quality control for e_file::unzipGithubArchive()
- MOD: PHPDoc for e_file::unzipGithubArchive()
- NEW: e_file::unzipGithubArchive(): Added exclusions for files that don't exist in production
- NEW: e_file::unzipGithubArchive(): Accept a destination path argument for a custom extraction location
- NEW: Restored unimplemented skipped list in e_file::unzipGithubArchive()
- FIX: e_file::unzipGithubArchive(): Extraction fails if parent directory of file doesn't exist
- MOD: Type hint for Base::$deployer
- NEW: Basic test for e_file::unzipGithubArchive()
2019-12-27 11:33:21 -06:00
Nick Liu
3fca73064a
Improvements to CONTRIBUTING.md 2019-12-26 11:05:17 -08:00
Nick Liu
38c8c71a09
Improvements to README.md
- MOD: Removed hard-coded version number
- NEW: Added badge for latest version number
- NEW: Added badge for build results
- NEW: Added badge for code coverage
- NEW: Added table of contents
- FIX: Clarification of system requirements
- MOD: Combined installation insructions into "Installation" secion
- MOD: Standard installation instructions now explain how to download e107
- FIX: Clarification of Git installation instructions
- FIX: Grammar in "Reporting Bugs" section
- MOD: Renamed "Pull-Requests" section to "Contributing to Development"
- FIX: Readability of the "Contributing to Development" section
- FIX: Grammar in "Donations" section
- MOD: Replaced all HTTP links with HTTPS
2019-12-26 11:05:11 -08:00
Nick Liu
16ca1494e3
GitHub Actions workflow renamed "Test e107" => "Unit Tests" 2019-12-26 10:18:26 -08:00
Nick Liu
ed58d40adb
Merge branch 'master' into test-harness
To verify that tests still pass with the latest changes
2019-12-25 16:30:45 -06:00
Nick Liu
6c168a2df6
pluginsTest: Ensure plugin is uninstalled before trying to install it 2019-12-25 13:56:58 -08:00
Nick Liu
0466841d2d
e_parseTest initialization order fix for flaky test? 2019-12-25 13:56:28 -08:00
Nick Liu
b3cf8df03c
Fixed inconsistent output in PHP < 7.3 in e_parser::cleanHtml()
- FIX: Workaround for https://bugs.php.net/bug.php?id=76285 present in PHP versions below 7.3 that maintains compatibility for PHP >= 7.3
2019-12-25 12:21:13 -08:00
Nick Liu
8c7d32c523
Fixed MPREFIX regression caused by a4c6fd8b
Caused by: a4c6fd8b5bf268ae7032acb14f4476a192a48b62

- FIX: MySQL table prefix is lost due to cyclic e_db_pdo::database() call that loses the prefix and reverts back to the default prefix, MPREFIX or "e107_".
2019-12-23 21:11:59 +01:00
Nick Liu
29999eed6d
Updated to Codeception 4.0 2019-12-23 19:51:18 +01:00
Nick Liu
f2edd94ea4
Fixed e_db_abstractTest::testDb_Select_gen() UPDATE query
A previous test may have changed the value so that the update would not have changed anything.
2019-12-23 18:40:18 +01:00
Nick Liu
9b59527b3d
Moved PDO-exclusive features from e_db_abstractTest to e_db_pdoTest
e_db_pdoTest::testSelectBind()
e_db_pdoTest::testDb_QueryBind()
e_db_pdoTest::testDb_CopyRowUnique()
2019-12-23 18:34:16 +01:00
Nick Liu
a93165efa5
Implemented missing e_db_mysql::resetTableList() method
e_db::resetTableList() is now an interface method (undocumented)
2019-12-23 17:12:47 +01:00
Nick Liu
a4ad81dd4c
Resolved e_db_mysql::db_Query() logging inconsistency
Logging change made in f34eeaf369678ddafe2842b391e3b1ec534aa324 for e_db_pdo was not applied to e_db_mysql

This commit makes the behaviors consistent between the two implementations of e_db.
2019-12-23 17:08:01 +01:00
Nick Liu
9677db1c1c
Removed bad e_LEGACY_MODE implementation
e_LEGACY_MODE caused the query results from e_db_pdo and e_db_mysql to return different styles (MYSQL_BOTH and MYSQL_ASSOC, respectively).

To resolve this inconsistency, e_LEGACY_MODE has been removed from the e107 core.
2019-12-23 16:50:33 +01:00
Nick Liu
71e7f8778c
Merged e_db_mysql and e_db_pdo tests into e_db_abstractTest
- FIX: e_db::copyTable() is now an interface
- FIX: e_db_mysql now implements e_db
- FIX: Implemented missing e_db_mysql::copyTable() public method
- FIX: Implemented missing e_db_mysql::setLanguage() method
- FIX: Implemented missing e_db_mysql::getLanguage() method
- FIX: Implemented missing e_db_mysql::dropTable() method
- MOD: Merged e_db_mysqlTest and e_db_pdoTest into e_db_abstractTest
2019-12-23 16:37:48 +01:00
Nick Liu
2330f8a152
Removed hard-coded SQL database creation 2019-12-23 15:28:52 +01:00
Nick Liu
f38e6c1f6d
Added a salt-ssh state to deploy an LXC dev env 2019-12-23 15:19:26 +01:00
Tijn Kuyper
fb727a0086
Closes - Add batch copy function to banner plugin 2019-12-16 17:58:48 +01:00
Tijn Kuyper
61fbc7f164
Fixes - Show menu link_text in bootstrap3 admin theme
Inadvertently got hidden when fixing 
2019-12-16 17:10:23 +01:00
Serios
a280ec029f
Fixing an issue that with contact form sending unnecessary additional data
There is an option that dev can add additional fields to contact form, that are sent back. But GDPR field is send back too, also if using NoCaptcha ReCaptcha plugin, response token from Google is send back too.
2019-12-16 15:29:41 +02:00
Tijn Kuyper
4a0404d917
Minor fix in userclass description 2019-12-11 17:08:15 +01:00
Tijn Kuyper
b364043125
Added two userclasses, updated e_formTest and e_user_modelTest to reflect the changes
1. TestImage1 - with a FontAwesome icon
2. TestImage2 - with a png icon (TinyMCE plugin icon)

Added user to those userclasses.
2019-12-11 17:00:17 +01:00
Cameron
ef4f34d223 Fixes - "Bad File Detected" when uppercase extension used on image. 2019-12-10 11:35:08 -08:00
Cameron
3087826ee9 Fixes - SEF Generation confirmation 'cancel' option was being ignored. Also, confirmation will now only appear if the current sef is not empty. 2019-12-06 13:12:42 -08:00