1
0
mirror of https://github.com/e107inc/e107.git synced 2025-01-29 18:47:54 +01:00

12412 Commits

Author SHA1 Message Date
Nick Liu
8d5d184ab2
Redesigned README.md above-the-fold content
- NEW: Logo at the top
- MOD: Moved Gitter badge to the end
- MOD: Added e107 logo to GitHub release badge
- MOD: Replaced GitHub Workflow badge with Shields.io equivalent for consistency
- MOD: Replaced Codecov code coverage badge with Code Climate equivalent
- MOD: Added Gitter logo and styling to Gitter badge
2019-12-28 18:23:13 +01:00
Nick Liu
939d01271c
GitHub Actions: Upload code coverage report to Code Climate as well 2019-12-28 16:57:30 +01:00
Nick Liu
4ca73daad5
Salt state e107-dev now installs LAMP for acceptance tests 2019-12-28 15:39:21 +01:00
Nick Liu
20ed1ecb00
Enable xdebug in PHP 5.6 builds 2019-12-28 10:58:07 +01:00
Nick Liu
60aa3f34d4
Refactored e_db_pdo::copyRow() for Codeception
Fixes: "The method copyRow() has an NPath complexity of 252. The configured NPath complexity threshold is 200."
2019-12-28 10:57:51 +01:00
Nick Liu
c31b645013
Made acceptance tests work again
Broken due to Codeception moving modules out of codeception/codeception
2019-12-28 10:35:36 +01:00
Nick Liu
e797efce74
Fixed some formatting oddities 2019-12-27 22:18:27 +01:00
Nick Liu
fabb0c2757
e_db_pdo::copyRow() - Greatly decrease collision chance
Increased possible random strings for unique fields in e_db_pdo::copyRow() from 1000 to 59^11 (UserHandler::generateRandomString() "alphanumeric" should have 59 characters to choose from)

If a collision still happens, e_db_pdo::copyRow() retries up to 3 times for a successful copy.

Fixes: #3678
2019-12-27 21:54:11 +01:00
Nick Liu
5e9b3bee14
Resolve Code Climate error about file not existing
Error message from Code Climate:

> Exception: The given file "/code/e107_tests/lib/ci/salt/pillars/config-local.sls" does not exist. in /usr/src/app/vendor/pdepend/pdepend/src/main/php/PDepend/Engine.php
> #0 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(129): PDepend\Engine->addFile('/code/e107_test...')
> #1 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(109): PHPMD\ParserFactory->initInput(Object(PDepend\Engine), Object(PHPMD\PHPMD))
> #2 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(76): PHPMD\ParserFactory->init(Object(PDepend\Engine), Object(PHPMD\PHPMD))
> #3 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/PHPMD.php(215): PHPMD\ParserFactory->create(Object(PHPMD\PHPMD))
> #4 /usr/src/app/Runner.php(116): PHPMD\PHPMD->processFiles('/code/e107_test...', 'cleancode,unuse...', Array, Object(PHPMD\RuleSetFactory))
> #5 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1852): CodeClimate\PHPMD\Runner->run(Array)
> #6 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1772): fork_daemon->invoke_callback(Array, Array, false)
> #7 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1673): fork_daemon->fork_work_unit(Array, '', -1)
> #8 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1445): fork_daemon->process_work_unit(-1)
> #9 /usr/src/app/Runner.php(31): fork_daemon->process_work(false)
> #10 /usr/src/app/engine.php(35): CodeClimate\PHPMD\Runner->queueDirectory('/code')
> #11 {main}
2019-12-27 19:35:19 +01:00
Nick Liu
3b4240bbae
Quality control for e_file::unzipGithubArchive()
- MOD: PHPDoc for e_file::unzipGithubArchive()
- NEW: e_file::unzipGithubArchive(): Added exclusions for files that don't exist in production
- NEW: e_file::unzipGithubArchive(): Accept a destination path argument for a custom extraction location
- NEW: Restored unimplemented skipped list in e_file::unzipGithubArchive()
- FIX: e_file::unzipGithubArchive(): Extraction fails if parent directory of file doesn't exist
- MOD: Type hint for Base::$deployer
- NEW: Basic test for e_file::unzipGithubArchive()
2019-12-27 11:33:21 -06:00
Nick Liu
3fca73064a
Improvements to CONTRIBUTING.md 2019-12-26 11:05:17 -08:00
Nick Liu
38c8c71a09
Improvements to README.md
- MOD: Removed hard-coded version number
- NEW: Added badge for latest version number
- NEW: Added badge for build results
- NEW: Added badge for code coverage
- NEW: Added table of contents
- FIX: Clarification of system requirements
- MOD: Combined installation insructions into "Installation" secion
- MOD: Standard installation instructions now explain how to download e107
- FIX: Clarification of Git installation instructions
- FIX: Grammar in "Reporting Bugs" section
- MOD: Renamed "Pull-Requests" section to "Contributing to Development"
- FIX: Readability of the "Contributing to Development" section
- FIX: Grammar in "Donations" section
- MOD: Replaced all HTTP links with HTTPS
2019-12-26 11:05:11 -08:00
Nick Liu
16ca1494e3
GitHub Actions workflow renamed "Test e107" => "Unit Tests" 2019-12-26 10:18:26 -08:00
Nick Liu
ed58d40adb
Merge branch 'master' into test-harness
To verify that tests still pass with the latest changes
2019-12-25 16:30:45 -06:00
Nick Liu
6c168a2df6
pluginsTest: Ensure plugin is uninstalled before trying to install it 2019-12-25 13:56:58 -08:00
Nick Liu
0466841d2d
e_parseTest initialization order fix for flaky test? 2019-12-25 13:56:28 -08:00
Nick Liu
b3cf8df03c
Fixed inconsistent output in PHP < 7.3 in e_parser::cleanHtml()
- FIX: Workaround for https://bugs.php.net/bug.php?id=76285 present in PHP versions below 7.3 that maintains compatibility for PHP >= 7.3
2019-12-25 12:21:13 -08:00
Nick Liu
8c7d32c523
Fixed MPREFIX regression caused by a4c6fd8b
Caused by: a4c6fd8b5bf268ae7032acb14f4476a192a48b62

- FIX: MySQL table prefix is lost due to cyclic e_db_pdo::database() call that loses the prefix and reverts back to the default prefix, MPREFIX or "e107_".
2019-12-23 21:11:59 +01:00
Nick Liu
29999eed6d
Updated to Codeception 4.0 2019-12-23 19:51:18 +01:00
Nick Liu
f2edd94ea4
Fixed e_db_abstractTest::testDb_Select_gen() UPDATE query
A previous test may have changed the value so that the update would not have changed anything.
2019-12-23 18:40:18 +01:00
Nick Liu
9b59527b3d
Moved PDO-exclusive features from e_db_abstractTest to e_db_pdoTest
e_db_pdoTest::testSelectBind()
e_db_pdoTest::testDb_QueryBind()
e_db_pdoTest::testDb_CopyRowUnique()
2019-12-23 18:34:16 +01:00
Nick Liu
a93165efa5
Implemented missing e_db_mysql::resetTableList() method
e_db::resetTableList() is now an interface method (undocumented)
2019-12-23 17:12:47 +01:00
Nick Liu
a4ad81dd4c
Resolved e_db_mysql::db_Query() logging inconsistency
Logging change made in f34eeaf369678ddafe2842b391e3b1ec534aa324 for e_db_pdo was not applied to e_db_mysql

This commit makes the behaviors consistent between the two implementations of e_db.
2019-12-23 17:08:01 +01:00
Nick Liu
9677db1c1c
Removed bad e_LEGACY_MODE implementation
e_LEGACY_MODE caused the query results from e_db_pdo and e_db_mysql to return different styles (MYSQL_BOTH and MYSQL_ASSOC, respectively).

To resolve this inconsistency, e_LEGACY_MODE has been removed from the e107 core.
2019-12-23 16:50:33 +01:00
Nick Liu
71e7f8778c
Merged e_db_mysql and e_db_pdo tests into e_db_abstractTest
- FIX: e_db::copyTable() is now an interface
- FIX: e_db_mysql now implements e_db
- FIX: Implemented missing e_db_mysql::copyTable() public method
- FIX: Implemented missing e_db_mysql::setLanguage() method
- FIX: Implemented missing e_db_mysql::getLanguage() method
- FIX: Implemented missing e_db_mysql::dropTable() method
- MOD: Merged e_db_mysqlTest and e_db_pdoTest into e_db_abstractTest
2019-12-23 16:37:48 +01:00
Nick Liu
2330f8a152
Removed hard-coded SQL database creation 2019-12-23 15:28:52 +01:00
Nick Liu
f38e6c1f6d
Added a salt-ssh state to deploy an LXC dev env 2019-12-23 15:19:26 +01:00
Tijn Kuyper
fb727a0086
Closes #4046 - Add batch copy function to banner plugin 2019-12-16 17:58:48 +01:00
Tijn Kuyper
61fbc7f164
Fixes #4020 - Show menu link_text in bootstrap3 admin theme
Inadvertently got hidden when fixing #2578
2019-12-16 17:10:23 +01:00
Serios
a280ec029f
Fixing an issue that with contact form sending unnecessary additional data
There is an option that dev can add additional fields to contact form, that are sent back. But GDPR field is send back too, also if using NoCaptcha ReCaptcha plugin, response token from Google is send back too.
2019-12-16 15:29:41 +02:00
Tijn Kuyper
4a0404d917
Minor fix in userclass description 2019-12-11 17:08:15 +01:00
Tijn Kuyper
b364043125
Added two userclasses, updated e_formTest and e_user_modelTest to reflect the changes
1. TestImage1 - with a FontAwesome icon
2. TestImage2 - with a png icon (TinyMCE plugin icon)

Added user to those userclasses.
2019-12-11 17:00:17 +01:00
Cameron
ef4f34d223 Fixes #4017 - "Bad File Detected" when uppercase extension used on image. 2019-12-10 11:35:08 -08:00
Cameron
3087826ee9 Fixes #4041 - SEF Generation confirmation 'cancel' option was being ignored. Also, confirmation will now only appear if the current sef is not empty. 2019-12-06 13:12:42 -08:00
Cameron
4bf21cbaa5 AdminUI: Fixes conflict between custom 'filter' dropdown and 'search' input. New method format added for custom search field processing independent of "Filter" processing. See handleListBanlistIpSearch() for an example. 2019-12-05 10:44:59 -08:00
Cameron
3b28884b56
Possible fixes. 2019-12-04 13:12:47 -06:00
Cameron
1ff3dd0f8d Fix for 'select' method - test validation. 2019-12-04 10:19:38 -08:00
Deltik
369142af55
Exclude tests in Code Climate 2019-12-04 11:03:29 -06:00
Deltik
4e7d76235c
Removed GitLab CI 2019-12-03 23:09:28 -06:00
Deltik
5ef7777a33
Configure Codecov to comment in GitHub project 2019-12-03 22:56:32 -06:00
Tijn Kuyper
4f57c36442
#2225 - Added {USER_USERCLASS_ICON} shortcode
/**
	 * @example: {USER_USERCLASS_ICON} returns the icons of all userclasses the user belongs to, seperated by a whitespace
	 * @example: {USER_USERCLASS_ICON: amount=1} // returns only one icon
	 * @example: {USER_USERCLASS_ICON: seperator=|} // returns the icons seperated by |
	 * @param array $parm
	 * @return string
	*/
2019-12-03 15:15:21 +01:00
Tijn Kuyper
1142738397
user_shortcodes code clean-up (no functional changes)
Formatting, indentation, empty lines
2019-12-03 14:36:13 +01:00
Deltik
283d30f9c1
Added GitHub issue templates 2019-12-02 16:59:03 -06:00
Deltik
0e2f441c39
Added a GitHub pull request template
Based on: bfcb82cb54/.github/PULL_REQUEST_TEMPLATE.md
2019-12-02 16:51:49 -06:00
Cameron
972fa1a29c Fixed Multiselect dropdown so that an empty value also gets saved. 2019-12-02 14:18:25 -08:00
Cameron
5cf54d07d2 Basic per-item search engine robots handling added to News and Pages. 2019-12-02 13:32:21 -08:00
Deltik
d1657560b7
Moved CONTRIBUTING.md to ./.github/ 2019-12-02 14:50:11 -06:00
Tijn Kuyper
e1504b91c0
#4036 - Escape hyphen in regex for PHP 7.3 compatibility 2019-12-01 15:31:47 +01:00
Tijn Kuyper
2b9969d47e
Fixes #4035 - {NEWSTITLE} fix PHP 7.3 compatibility 2019-12-01 15:17:40 +01:00
Deltik
8d60076054
Fail GitHub Actions build when any tests fail 2019-11-28 23:00:56 -06:00