mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-17 14:51:19 +02:00
Code Issues Releases Wiki Activity

Fix 0s in notification dropdown

Browse Source 
By casting the length int to a bool, if there are no badges, we don't display a  0. It seems that mithril will render integers, but not booleans.

Fixes https://github.com/flarum/QualityAssurance/issues/28
This commit is contained in:
Alexander Skvortsov
2021-05-14 21:08:48 -04:00
parent 99deb2514d
commit 0289a3b714
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
framework/core/js/src/forum/components/NotificationList.js
View File

@@ -73,7 +73,7 @@ export default class NotificationList extends Component {
<div className="NotificationGroup"> <div className="NotificationGroup">
{group.discussion ? ( {group.discussion ? (
<Link className="NotificationGroup-header" href={app.route.discussion(group.discussion)}> <Link className="NotificationGroup-header" href={app.route.discussion(group.discussion)}>
{badges && badges.length && <ul className="NotificationGroup-badges badges">{listItems(badges)}</ul>} {badges && !!badges.length && <ul className="NotificationGroup-badges badges">{listItems(badges)}</ul>}
<span>{group.discussion.title()}</span> <span>{group.discussion.title()}</span>
</Link> </Link>
) : ( ) : (