mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-23 09:41:26 +02:00
Code Issues Releases Wiki Activity

Fix potential error when discussion doesn't exist

Browse Source 
Not sure how this could be the case, but can't hurt to add the checks.
addresses #343
This commit is contained in:
Toby Zerner
2015-09-01 10:07:13 +09:30
parent e4828f49a4
commit 04e711a611
1 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
framework/core/src/Core/Discussions/Listeners/DiscussionMetadataUpdater.php
View File

@@ -37,11 +37,13 @@ class DiscussionMetadataUpdater
{ {
$discussion = $event->post->discussion; $discussion = $event->post->discussion;
if ($discussion && $discussion->exists) {
$discussion->comments_count++; $discussion->comments_count++;
$discussion->setLastPost($event->post); $discussion->setLastPost($event->post);
$discussion->refreshParticipantsCount(); $discussion->refreshParticipantsCount();
$discussion->save(); $discussion->save();
} }
}
/** /**
* @param \Flarum\Events\PostWasDeleted $event * @param \Flarum\Events\PostWasDeleted $event
@@ -66,11 +68,13 @@ class DiscussionMetadataUpdater
{ {
$discussion = $event->post->discussion; $discussion = $event->post->discussion;
if ($discussion && $discussion->exists) {
$discussion->refreshCommentsCount(); $discussion->refreshCommentsCount();
$discussion->refreshParticipantsCount(); $discussion->refreshParticipantsCount();
$discussion->refreshLastPost(); $discussion->refreshLastPost();
$discussion->save(); $discussion->save();
} }
}
/** /**
* @param Post $post * @param Post $post
@@ -79,7 +83,7 @@ class DiscussionMetadataUpdater
{ {
$discussion = $post->discussion; $discussion = $post->discussion;
if ($discussion->exists) { if ($discussion && $discussion->exists) {
$discussion->refreshCommentsCount(); $discussion->refreshCommentsCount();
$discussion->refreshParticipantsCount(); $discussion->refreshParticipantsCount();