From 055efe21d6e010b16ca44c38346f5b54f83b79b1 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Mon, 10 Aug 2015 16:47:00 +0930 Subject: [PATCH] Cast discussion ID to string for comparison --- extensions/pusher/js/forum/src/main.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/extensions/pusher/js/forum/src/main.js b/extensions/pusher/js/forum/src/main.js index 0ac8a5d6e..c7fdaa4b3 100644 --- a/extensions/pusher/js/forum/src/main.js +++ b/extensions/pusher/js/forum/src/main.js @@ -43,8 +43,10 @@ app.initializers.add('pusher', () => { if (data.tagIds.indexOf(tag.id()) === -1) return; } - if ((!app.current.discussion || data.discussionId !== app.current.discussion.id()) && app.pushedUpdates.indexOf(data.discussionId) === -1) { - app.pushedUpdates.push(data.discussionId); + const id = String(data.discussionId); + + if ((!app.current.discussion || id !== app.current.discussion.id()) && app.pushedUpdates.indexOf(id) === -1) { + app.pushedUpdates.push(id); if (app.current instanceof IndexPage) { app.setTitleCount(app.pushedUpdates.length); @@ -107,7 +109,9 @@ app.initializers.add('pusher', () => { app.pusher.then(channels => { channels.main.bind('newPost', data => { - if (this.discussion && this.discussion.id() === data.discussionId && this.stream) { + const id = String(data.discussionId); + + if (this.discussion && this.discussion.id() === id && this.stream) { const oldCount = this.discussion.commentsCount(); app.store.find('discussions', this.discussion.id()).then(() => {