From 07f04c7ba7ea94cb03513c441a5eecd09765e462 Mon Sep 17 00:00:00 2001 From: Alexander Skvortsov Date: Fri, 4 Sep 2020 17:43:57 -0400 Subject: [PATCH] Use `some` for needsRebuild in SubtreeRetainer --- js/src/common/utils/SubtreeRetainer.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/js/src/common/utils/SubtreeRetainer.js b/js/src/common/utils/SubtreeRetainer.js index a28d6e3a0..9f00511aa 100644 --- a/js/src/common/utils/SubtreeRetainer.js +++ b/js/src/common/utils/SubtreeRetainer.js @@ -33,18 +33,16 @@ export default class SubtreeRetainer { * @public */ needsRebuild() { - let needsRebuild = false; - - this.callbacks.forEach((callback, i) => { + return this.callbacks.some((callback, i) => { const result = callback(); if (result !== this.data[i]) { this.data[i] = result; - needsRebuild = true; + return true; } - }); - return needsRebuild; + return false; + }); } /**