From 0f75139a516bae8355996516a92b69e6b6b262d4 Mon Sep 17 00:00:00 2001 From: Charlie Date: Mon, 19 Mar 2018 22:49:15 +0100 Subject: [PATCH] Fix ordering bug If an empty request is sent to the /tags/order endpoint, all tags would get moved to secondary tags. --- extensions/tags/src/Api/Controller/OrderTagsController.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/extensions/tags/src/Api/Controller/OrderTagsController.php b/extensions/tags/src/Api/Controller/OrderTagsController.php index 5c5a12a30..d324dd8de 100644 --- a/extensions/tags/src/Api/Controller/OrderTagsController.php +++ b/extensions/tags/src/Api/Controller/OrderTagsController.php @@ -30,6 +30,10 @@ class OrderTagsController implements ControllerInterface $order = array_get($request->getParsedBody(), 'order'); + if ($order === null) { + return new EmptyResponse(422); + } + Tag::query()->update([ 'position' => null, 'parent_id' => null