From 12bfff9b5d24a15a6bf3d61431a278f159cbebd7 Mon Sep 17 00:00:00 2001 From: Alexander Skvortsov Date: Tue, 29 Sep 2020 18:37:26 -0400 Subject: [PATCH] Rename onshow and onhide animateShow and animateHide are more descriptive --- framework/core/js/src/common/components/Modal.js | 4 ++-- framework/core/js/src/common/components/ModalManager.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/framework/core/js/src/common/components/Modal.js b/framework/core/js/src/common/components/Modal.js index 97e3a273e..0d621060a 100644 --- a/framework/core/js/src/common/components/Modal.js +++ b/framework/core/js/src/common/components/Modal.js @@ -24,7 +24,7 @@ export default class Modal extends Component { oncreate(vnode) { super.oncreate(vnode); - this.attrs.onshow(() => this.onready()); + this.attrs.animateShow(() => this.onready()); } onbeforeremove() { @@ -32,7 +32,7 @@ export default class Modal extends Component { // we've just opened up a new one, and accordingly, // we don't need to show a hide animation. if (!this.attrs.state.modal) { - this.attrs.onhide(); + this.attrs.animateHide(); } } diff --git a/framework/core/js/src/common/components/ModalManager.js b/framework/core/js/src/common/components/ModalManager.js index b4c8814b3..9d0609c18 100644 --- a/framework/core/js/src/common/components/ModalManager.js +++ b/framework/core/js/src/common/components/ModalManager.js @@ -14,8 +14,8 @@ export default class ModalManager extends Component { {modal ? modal.componentClass.component({ ...modal.attrs, - onshow: this.animateShow.bind(this), - onhide: this.animateHide.bind(this), + animateShow: this.animateShow.bind(this), + animateHide: this.animateHide.bind(this), state: this.attrs.state, }) : ''}