From 1665d47adcfb980084f41f5f571a23577f765796 Mon Sep 17 00:00:00 2001
From: IanM <16573496+imorland@users.noreply.github.com>
Date: Thu, 3 Oct 2024 09:01:17 +0100
Subject: [PATCH] fix: compat: still return controls view item, even if empty
 (#4057)

---
 .../forum/components/DiscussionListItem.tsx   | 22 +++++++++++--------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/framework/core/js/src/forum/components/DiscussionListItem.tsx b/framework/core/js/src/forum/components/DiscussionListItem.tsx
index dd5ebba47..da7df0515 100644
--- a/framework/core/js/src/forum/components/DiscussionListItem.tsx
+++ b/framework/core/js/src/forum/components/DiscussionListItem.tsx
@@ -74,7 +74,7 @@ export default class DiscussionListItem<CustomAttrs extends IDiscussionListItemA
     const discussion = this.attrs.discussion;
     const controls = DiscussionControls.controls(discussion, this).toArray();
 
-    !!controls.length && items.add('controls', this.controlsView(controls), 100);
+    items.add('controls', this.controlsView(controls), 100);
     items.add('slidableUnderneath', this.slidableUnderneathView(), 90);
     items.add('content', this.contentView(), 80);
 
@@ -83,14 +83,18 @@ export default class DiscussionListItem<CustomAttrs extends IDiscussionListItemA
 
   controlsView(controls: Mithril.ChildArray): Mithril.Children {
     return (
-      <Dropdown
-        icon="fas fa-ellipsis-v"
-        className="DiscussionListItem-controls"
-        buttonClassName="Button Button--icon Button--flat Slidable-underneath Slidable-underneath--right"
-        accessibleToggleLabel={app.translator.trans('core.forum.discussion_controls.toggle_dropdown_accessible_label')}
-      >
-        {controls}
-      </Dropdown>
+      <>
+        {!!controls.length && (
+          <Dropdown
+            icon="fas fa-ellipsis-v"
+            className="DiscussionListItem-controls"
+            buttonClassName="Button Button--icon Button--flat Slidable-underneath Slidable-underneath--right"
+            accessibleToggleLabel={app.translator.trans('core.forum.discussion_controls.toggle_dropdown_accessible_label')}
+          >
+            {controls}
+          </Dropdown>
+        )}
+      </>
     );
   }