mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-05-16 04:09:41 +02:00
Code Issues Releases Wiki Activity

fix: disallow certain dangerous LESS features

Browse Source 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
This commit is contained in:
Sami Mazouz 2023-03-04 20:38:19 +01:00
parent 8ddb0feb09
commit 1761660c98
No known key found for this signature in database
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
framework/core/locale/core.yml
View File

@ -18,6 +18,7 @@ core:
custom_footer_text: => core.ref.custom_footer_text custom_footer_text: => core.ref.custom_footer_text
custom_header_heading: Custom Header custom_header_heading: Custom Header
custom_header_text: => core.ref.custom_header_text custom_header_text: => core.ref.custom_header_text
custom_styles_cannot_use_less_features: "The @import and data-uri features are not allowed in custom LESS."
custom_styles_heading: Custom Styles custom_styles_heading: Custom Styles
custom_styles_text: Customize your forum's appearance by adding your own Less/CSS code to be applied on top of Flarum's default styles. custom_styles_text: Customize your forum's appearance by adding your own Less/CSS code to be applied on top of Flarum's default styles.
dark_mode_label: Dark Mode dark_mode_label: Dark Mode

10
framework/core/src/Forum/ValidateCustomLess.php
View File

@ -21,6 +21,7 @@ use Illuminate\Filesystem\FilesystemAdapter;
use League\Flysystem\Adapter\NullAdapter; use League\Flysystem\Adapter\NullAdapter;
use League\Flysystem\Filesystem; use League\Flysystem\Filesystem;
use Less_Exception_Parser; use Less_Exception_Parser;
use Symfony\Contracts\Translation\TranslatorInterface;
/** /**
* @internal * @internal
@ -61,6 +62,15 @@ class ValidateCustomLess
return; return;
} }
// Restrict what features can be used in custom LESS
if (preg_match('/@import|data-uri\s*\(/i', $event->settings['custom_less'])) {
$translator = $this->container->make(TranslatorInterface::class);
throw new ValidationException([
'custom_less' => $translator->trans('core.admin.appearance.custom_styles_cannot_use_less_features')
]);
}
// We haven't saved the settings yet, but we want to trial a full // We haven't saved the settings yet, but we want to trial a full
// recompile of the CSS to see if this custom LESS will break // recompile of the CSS to see if this custom LESS will break
// anything. In order to do that, we will temporarily override the // anything. In order to do that, we will temporarily override the