Clean up usages / deprecate path helpers (#2155)

Browse Source

* Write source map without creating temp file

Less I/O, and one less place where we access the global path helpers.

* Drop useless app_path() helper

This was probably taken straight from Laravel. There is no equivalent
concept in Flarum, so this should be safe to remove.

* Deprecate global path helpers

Developers using these helpers can inject the `Paths` class instead.

* Stop storing paths as strings in container

* Avoid using path helpers from Application class

* Deprecate path helpers from Application class

* Avoid using public_path() in prerequisite check

a) The comparison was already outdated, as a different path was passed.
b) We're trying to get rid of these global helpers.

...

This commit is contained in:

Franz Liedke

2020-06-19 22:16:03 +02:00

committed by GitHub

parent be5ffad574

commit 17eac0fa4a

13 changed files with 143 additions and 77 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

0

framework/core/tests/fixtures/writable_paths/writable/.keep vendored Normal file