From 18f19604816b0211397d7f8a2c627c2566005069 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Tue, 3 Nov 2015 17:41:31 +1030 Subject: [PATCH] Prevent browser tooltip from appearing Bootstrap JS was clearing the `title` attribute, but then Mithril was redrawing and filling it back in. --- .../forum/src/components/SubscriptionMenu.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/extensions/subscriptions/js/forum/src/components/SubscriptionMenu.js b/extensions/subscriptions/js/forum/src/components/SubscriptionMenu.js index 3c1299216..d5889ed1e 100644 --- a/extensions/subscriptions/js/forum/src/components/SubscriptionMenu.js +++ b/extensions/subscriptions/js/forum/src/components/SubscriptionMenu.js @@ -63,14 +63,16 @@ export default class SubscriptionMenu extends Component { const notifyAlert = preferences['notify_newPost_alert']; if ((notifyEmail || notifyAlert) && subscription === false) { - buttonProps.title = app.translator.trans(notifyEmail - ? 'flarum-subscriptions.forum.sub_controls.notify_email_tooltip' - : 'flarum-subscriptions.forum.sub_controls.notify_alert_tooltip'); - buttonProps.config = element => $(element).tooltip({ - container: '.SubscriptionMenu', - placement: 'bottom', - delay: 250 - }); + buttonProps.config = element => { + $(element).tooltip({ + container: '.SubscriptionMenu', + placement: 'bottom', + delay: 250, + title: app.translator.trans(notifyEmail + ? 'flarum-subscriptions.forum.sub_controls.notify_email_tooltip' + : 'flarum-subscriptions.forum.sub_controls.notify_alert_tooltip') + }); + } } else { buttonProps.config = element => $(element).tooltip('destroy'); }