mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-10-11 06:54:26 +02:00
Code Issues Releases Wiki Activity

Better API error handling

Browse Source
This commit is contained in:
Toby Zerner
2015-05-18 18:13:16 +09:30
parent 9f42fbe450
commit 1b4b03356a
9 changed files with 74 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/Api/Actions/SerializeAction.php
View File

@@ -3,14 +3,11 @@
use Flarum\Api\Request;
use Flarum\Api\JsonApiRequest;
use Flarum\Api\JsonApiResponse;
use Flarum\Core\Exceptions\ValidationFailureException;
use Flarum\Core\Exceptions\PermissionDeniedException;
use Tobscure\JsonApi\SerializerInterface;
use Tobscure\JsonApi\Criteria;
use Illuminate\Http\Response;
use Illuminate\Http\JsonResponse;
abstract class SerializeAction implements ActionInterface
abstract class SerializeAction extends JsonApiAction
{
/**
* The name of the serializer class to output results with.
@@ -68,24 +65,11 @@ abstract class SerializeAction implements ActionInterface
* @param \Flarum\Api\Request $request
* @return \Flarum\Api\Response
*/
public function handle(Request $request)
public function respond(Request $request)
{
$request = static::buildJsonApiRequest($request);
try {
$data = $this->data($request, $response = new JsonApiResponse);
} catch (ValidationFailureException $e) {
$errors = [];
foreach ($e->getErrors()->getMessages() as $field => $messages) {
$errors[] = [
'detail' => implode("\n", $messages),
'path' => $field
];
}
return new JsonResponse(['errors' => $errors], 422);
} catch (PermissionDeniedException $e) {
return new JsonResponse(null, 401);
}
$data = $this->data($request, $response = new JsonApiResponse);
$serializer = new static::$serializer($request->actor, $request->include, $request->link);