mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-10-22 20:26:15 +02:00
Code Issues Releases Wiki Activity

Revert BC breaks around notification blueprints

Browse Source 
No need for breaking backwards compatibility here - encapsulating the
logic for `getAttributes()` in one place turns out to be quite useful.

Refs #1931.
This commit is contained in:
Franz Liedke
2020-04-03 11:33:33 +02:00
parent e16d57d4e2
commit 1cda9dca4f
5 changed files with 54 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Notification/Blueprint/BlueprintInterface.php
View File

@@ -22,7 +22,6 @@ interface BlueprintInterface
/**
* Get the user that sent the notification.
*
* @deprecated Will be removed for beta.14
* @return User|null
*/
public function getFromUser();
@@ -30,7 +29,6 @@ interface BlueprintInterface
/**
* Get the model that is the subject of this activity.
*
* @deprecated Will be removed for beta.14
* @return AbstractModel|null
*/
public function getSubject();
@@ -38,19 +36,10 @@ interface BlueprintInterface
/**
* Get the data to be stored in the notification.
*
* @deprecated Will be removed for beta.14
* @return array|null
*/
public function getData();
/**
* Get the attributes that uniquely identify a notification, plus metadata.
* TODO: Uncomment this for beta.14.
*
* @return array
*/
//public function getAttributes(): array;
/**
* Get the serialized type of this activity.
*