From 31c3cfc4eab4c314260b9b0d11e53ac2d4be158d Mon Sep 17 00:00:00 2001 From: Sami Mazouz Date: Fri, 16 Sep 2022 10:54:39 +0100 Subject: [PATCH] chore(package-manager): set min core version and add warning Signed-off-by: Sami Mazouz --- extensions/package-manager/composer.json | 2 +- extensions/package-manager/js/src/admin/index.tsx | 8 ++++++++ extensions/package-manager/locale/en.yml | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/extensions/package-manager/composer.json b/extensions/package-manager/composer.json index 449c0a4e7..ad579cfeb 100755 --- a/extensions/package-manager/composer.json +++ b/extensions/package-manager/composer.json @@ -22,7 +22,7 @@ "source": "https://github.com/flarum/package-manager" }, "require": { - "flarum/core": "^1.0.0", + "flarum/core": "^1.5.0", "composer/composer": "^2.3" }, "require-dev": { diff --git a/extensions/package-manager/js/src/admin/index.tsx b/extensions/package-manager/js/src/admin/index.tsx index 65b46e32e..7d04770c7 100755 --- a/extensions/package-manager/js/src/admin/index.tsx +++ b/extensions/package-manager/js/src/admin/index.tsx @@ -11,6 +11,7 @@ import jumpToQueue from './utils/jumpToQueue'; import extractText from 'flarum/common/utils/extractText'; import { AsyncBackendResponse } from './shims'; import PackageManagerState from './states/PackageManagerState'; +import Alert from "@flarum/core/src/common/components/Alert"; app.initializers.add('flarum-package-manager', (app) => { app.store.models['package-manager-tasks'] = Task; @@ -19,6 +20,13 @@ app.initializers.add('flarum-package-manager', (app) => { app.extensionData .for('flarum-package-manager') + .registerSetting(() => ( +
+ + {app.translator.trans('flarum-package-manager.admin.settings.access_warning')} + +
+ )) .registerSetting({ setting: 'flarum-package-manager.queue_jobs', label: app.translator.trans('flarum-package-manager.admin.settings.queue_jobs'), diff --git a/extensions/package-manager/locale/en.yml b/extensions/package-manager/locale/en.yml index 0416c8193..607449dfb 100755 --- a/extensions/package-manager/locale/en.yml +++ b/extensions/package-manager/locale/en.yml @@ -72,6 +72,7 @@ flarum-package-manager: title: Queue settings: + access_warning: Please be careful to who you give access to the admin area, the package manager could be misused by bad actors to install packages that can lead to security breaches. queue_jobs: Run operations in the background queue queue_jobs_help: > You can read about a basic queue implementation or a more advanced one.