From 3343fde5f270348121e1831075422f2bb08ef7b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20Klabbers?= Date: Wed, 23 Mar 2022 12:04:56 +0100 Subject: [PATCH] add distinct and clean up code further --- extensions/tags/src/Query/TagFilterGambit.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/extensions/tags/src/Query/TagFilterGambit.php b/extensions/tags/src/Query/TagFilterGambit.php index 70b8afc6b..e4bf8d451 100644 --- a/extensions/tags/src/Query/TagFilterGambit.php +++ b/extensions/tags/src/Query/TagFilterGambit.php @@ -55,9 +55,10 @@ class TagFilterGambit extends AbstractRegexGambit implements FilterInterface { $slugs = explode(',', trim($rawSlugs, '"')); - $query->leftJoin('discussion_tag', 'discussions.id', '=', 'discussion_tag.discussion_id'); - - $query->where(function (Builder $query) use ($slugs, $negate) { + $query + ->distinct() + ->leftJoin('discussion_tag', 'discussions.id', '=', 'discussion_tag.discussion_id') + ->where(function (Builder $query) use ($slugs, $negate) { foreach ($slugs as $slug) { if ($slug === 'untagged' && ! $negate) { $query->orWhereNull('discussion_tag.tag_id');