mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-25 18:51:40 +02:00
Code Issues Releases Wiki Activity

Don't use browser scroll restore in DiscussionPage (#2476)

Browse Source 
Although native browser scroll restorations have become quite powerful, it interferes with Flarum's PostStream, so if we're on a DiscussionPage, we use manual scroll restoration.
This commit is contained in:
Alexander Skvortsov
2020-11-30 14:01:08 -05:00
committed by GitHub
parent c100316451
commit 35228b4b27
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
framework/core/js/src/common/components/Page.js
View File

@@ -29,6 +29,13 @@ export default class Page extends Component {
* @type {Boolean} * @type {Boolean}
*/ */
this.scrollTopOnCreate = true; this.scrollTopOnCreate = true;
/**
* Whether the browser should restore scroll state on refreshes.
*
* @type {Boolean}
*/
this.useBrowserScrollRestoration = true;
} }
oncreate(vnode) { oncreate(vnode) {
@@ -41,6 +48,10 @@ export default class Page extends Component {
if (this.scrollTopOnCreate) { if (this.scrollTopOnCreate) {
$(window).scrollTop(0); $(window).scrollTop(0);
} }
if ('scrollRestoration' in history) {
history.scrollRestoration = this.useBrowserScrollRestoration ? 'auto' : 'manual';
}
} }
onremove() { onremove() {

2
framework/core/js/src/forum/components/DiscussionPage.js
View File

@@ -18,6 +18,8 @@ export default class DiscussionPage extends Page {
oninit(vnode) { oninit(vnode) {
super.oninit(vnode); super.oninit(vnode);
this.useBrowserScrollRestoration = false;
/** /**
* The discussion that is being viewed. * The discussion that is being viewed.
* *