From 3c3f8242e2350caf169b490986dee3897393e961 Mon Sep 17 00:00:00 2001
From: Toby Zerner <toby.zerner@gmail.com>
Date: Sat, 28 Mar 2015 11:45:33 +1030
Subject: [PATCH] Remove unneeded check in item-list template
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If the `isHiddenInList` property is changed to true (e.g. via a
computed property), then that view is removed, and its computed
properties are unhooks — so the `isHiddenInList` property won’t update
and the view can’t be shown again. Items should be hidden via CSS
instead.
---
 ember/app/templates/components/ui/item-list.hbs | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/ember/app/templates/components/ui/item-list.hbs b/ember/app/templates/components/ui/item-list.hbs
index 939fad1c3..039cbdbe5 100644
--- a/ember/app/templates/components/ui/item-list.hbs
+++ b/ember/app/templates/components/ui/item-list.hbs
@@ -1,9 +1,7 @@
 {{#each item in listItems}}
-  {{#unless item.isHiddenInList}}
-    {{#if item.isListItem}}
-      {{view item}}
-    {{else}}
-      <li class="{{item.listItemClass}}">{{view item}}</li>
-    {{/if}}
-  {{/unless}}
+  {{#if item.isListItem}}
+    {{view item}}
+  {{else}}
+    <li class="{{item.listItemClass}}">{{view item}}</li>
+  {{/if}}
 {{/each}}