mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-05 07:57:46 +02:00
Code Issues Releases Wiki Activity

fix: increase length of email field (#4118)

Browse Source
This commit is contained in:
Davide Iadeluca
2024-11-22 11:03:04 +01:00
committed by GitHub
parent 7cfa560b4e
commit 49064f6912
3 changed files with 111 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
framework/core/migrations/2024_11_18_000000_increase_email_field_length_of_users.php Normal file
View File

@@ -0,0 +1,25 @@
<?php
/*
* This file is part of Flarum.
*
* For detailed copyright and license information, please view the
* LICENSE file that was distributed with this source code.
*/
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Schema\Builder;
return [
'up' => function (Builder $schema) {
$schema->table('users', function (Blueprint $table) {
$table->string('email', 254)->change();
});
},
'down' => function (Builder $schema) {
$schema->table('users', function (Blueprint $table) {
$table->string('email', 150)->change();
});
}
];

25
framework/core/migrations/2024_11_22_000000_increase_email_field_length_in_email_tokens.php Normal file
View File

@@ -0,0 +1,25 @@
<?php
/*
* This file is part of Flarum.
*
* For detailed copyright and license information, please view the
* LICENSE file that was distributed with this source code.
*/
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Schema\Builder;
return [
'up' => function (Builder $schema) {
$schema->table('email_tokens', function (Blueprint $table) {
$table->string('email', 254)->change();
});
},
'down' => function (Builder $schema) {
$schema->table('email_tokens', function (Blueprint $table) {
$table->string('email', 150)->change();
});
}
];

61
framework/core/tests/integration/api/users/CreateTest.php
View File

@@ -138,6 +138,67 @@ class CreateTest extends TestCase
$this->assertEquals(1, $user->is_email_confirmed); $this->assertEquals(1, $user->is_email_confirmed);
} }
#[Test]
public function admin_can_create_user_with_longest_valid_email()
{
$localPart = str_repeat('a', 64);
$domain = str_repeat('a', 61).'.'.str_repeat('a', 60).'.'.str_repeat('a', 60).'.local';
$email = $localPart.'@'.$domain;
$response = $this->send(
$this->request(
'POST',
'/api/users',
[
'authenticatedAs' => 1,
'json' => [
'data' => [
'attributes' => [
'username' => 'test',
'password' => 'too-obscure',
'email' => $email,
],
]
],
]
)
);
$this->assertEquals(201, $response->getStatusCode());
/** @var User $user */
$user = User::where('username', 'test')->firstOrFail();
$this->assertEquals($email, $user->email);
}
#[Test]
public function admin_cannot_create_user_with_invalid_email_length()
{
$email = str_repeat('a', 65).'@'.str_repeat('a', 256).'.local';
$response = $this->send(
$this->request(
'POST',
'/api/users',
[
'authenticatedAs' => 1,
'json' => [
'data' => [
'attributes' => [
'username' => 'test',
'password' => 'too-obscure',
'email' => $email,
],
]
],
]
)
);
$this->assertEquals(422, $response->getStatusCode());
}
#[Test] #[Test]
public function disabling_sign_up_prevents_user_creation() public function disabling_sign_up_prevents_user_creation()
{ {