From 4b05e0073a2a8182a3bca3f48c1bacbba6cd025c Mon Sep 17 00:00:00 2001 From: Alexander Skvortsov Date: Sat, 15 Aug 2020 19:12:14 -0400 Subject: [PATCH] Don't accept unnecessary vnode argument where it isn't used --- js/src/common/components/ConfirmDocumentUnload.js | 2 +- js/src/common/components/ModalManager.js | 2 +- js/src/forum/components/CommentPost.js | 4 ++-- js/src/forum/components/CommentPostPreview.js | 2 +- js/src/forum/components/DiscussionListPane.js | 2 +- js/src/forum/components/DiscussionPage.js | 2 +- js/src/forum/components/IndexPage.js | 4 ++-- js/src/forum/components/Post.js | 2 +- js/src/forum/components/PostEdited.js | 2 +- js/src/forum/components/PostStream.js | 4 ++-- js/src/forum/components/ReplyPlaceholderPreview.js | 2 +- 11 files changed, 14 insertions(+), 14 deletions(-) diff --git a/js/src/common/components/ConfirmDocumentUnload.js b/js/src/common/components/ConfirmDocumentUnload.js index 50b4d899f..5d1737ab8 100644 --- a/js/src/common/components/ConfirmDocumentUnload.js +++ b/js/src/common/components/ConfirmDocumentUnload.js @@ -27,7 +27,7 @@ export default class ConfirmDocumentUnload extends Component { $(window).on('beforeunload', this.handler.bind(this)); } - onremove(vnode) { + onremove() { $(window).off('beforeunload', this.handler.bind(this)); } diff --git a/js/src/common/components/ModalManager.js b/js/src/common/components/ModalManager.js index 8a36d7bba..6273e60e7 100644 --- a/js/src/common/components/ModalManager.js +++ b/js/src/common/components/ModalManager.js @@ -16,7 +16,7 @@ export default class ModalManager extends Component { ); } - onupdate(vnode) { + onupdate() { if (this.$('Modal') && !this.attrs.state.modal) { this.animateHide(); } diff --git a/js/src/forum/components/CommentPost.js b/js/src/forum/components/CommentPost.js index 979940ad8..5c49728e0 100644 --- a/js/src/forum/components/CommentPost.js +++ b/js/src/forum/components/CommentPost.js @@ -53,8 +53,8 @@ export default class CommentPost extends Post { ]); } - onupdate(vnode) { - super.onupdate(vnode); + onupdate() { + super.onupdate(); const contentHtml = this.isEditing() ? '' : this.attrs.post.contentHtml(); diff --git a/js/src/forum/components/CommentPostPreview.js b/js/src/forum/components/CommentPostPreview.js index db41031f2..f20533d07 100644 --- a/js/src/forum/components/CommentPostPreview.js +++ b/js/src/forum/components/CommentPostPreview.js @@ -27,7 +27,7 @@ export default class CommentPostPreview extends Component { this.updateInterval = setInterval(updatePreview, 50); } - onremove(vnode) { + onremove() { clearInterval(this.updateInterval); } } diff --git a/js/src/forum/components/DiscussionListPane.js b/js/src/forum/components/DiscussionListPane.js index 2f5c96836..3474ea7c7 100644 --- a/js/src/forum/components/DiscussionListPane.js +++ b/js/src/forum/components/DiscussionListPane.js @@ -41,7 +41,7 @@ export default class DiscussionListPane extends Component { } } - onremove(vnode) { + onremove() { $(document).off('mousemove', hotEdge); } } diff --git a/js/src/forum/components/DiscussionPage.js b/js/src/forum/components/DiscussionPage.js index 6f63d33ad..499dda8eb 100644 --- a/js/src/forum/components/DiscussionPage.js +++ b/js/src/forum/components/DiscussionPage.js @@ -51,7 +51,7 @@ export default class DiscussionPage extends Page { this.prevRoute = m.route.get(); } - onremove(vnode) { + onremove() { // If we are indeed navigating away from this discussion, then disable the // discussion list pane. Also, if we're composing a reply to this // discussion, minimize the composer – unless it's empty, in which case diff --git a/js/src/forum/components/IndexPage.js b/js/src/forum/components/IndexPage.js index b654d1320..67266fc49 100644 --- a/js/src/forum/components/IndexPage.js +++ b/js/src/forum/components/IndexPage.js @@ -125,8 +125,8 @@ export default class IndexPage extends Page { } } - onremove(vnode) { - super.onremove(vnode); + onremove() { + super.onremove(); $('#app').css('min-height', ''); diff --git a/js/src/forum/components/Post.js b/js/src/forum/components/Post.js index 35004352f..ebc084f73 100644 --- a/js/src/forum/components/Post.js +++ b/js/src/forum/components/Post.js @@ -84,7 +84,7 @@ export default class Post extends Component { return this.subtree.needsRebuild(); } - onupdate(vnode) { + onupdate() { const $actions = this.$('.Post-actions'); const $controls = this.$('.Post-controls'); diff --git a/js/src/forum/components/PostEdited.js b/js/src/forum/components/PostEdited.js index 0ea72e024..9f7756241 100644 --- a/js/src/forum/components/PostEdited.js +++ b/js/src/forum/components/PostEdited.js @@ -34,7 +34,7 @@ export default class PostEdited extends Component { ); } - onupdate(vnode) { + onupdate() { if (this.shouldUpdateTooltip) { this.$().tooltip('destroy').tooltip(); this.shouldUpdateTooltip = false; diff --git a/js/src/forum/components/PostStream.js b/js/src/forum/components/PostStream.js index dbfb791a8..5440c83f1 100644 --- a/js/src/forum/components/PostStream.js +++ b/js/src/forum/components/PostStream.js @@ -104,7 +104,7 @@ export default class PostStream extends Component { return
{items}
; } - onupdate(vnode) { + onupdate() { this.triggerScroll(); } @@ -118,7 +118,7 @@ export default class PostStream extends Component { setTimeout(() => this.scrollListener.start()); } - onremove(vnode) { + onremove() { this.scrollListener.stop(); clearTimeout(this.calculatePositionTimeout); } diff --git a/js/src/forum/components/ReplyPlaceholderPreview.js b/js/src/forum/components/ReplyPlaceholderPreview.js index 538dd5ab5..cc99a71a2 100644 --- a/js/src/forum/components/ReplyPlaceholderPreview.js +++ b/js/src/forum/components/ReplyPlaceholderPreview.js @@ -34,7 +34,7 @@ export default class ReplyPlaceholderPreview extends Component { }, 50); } - onremove(vnode) { + onremove() { clearInterval(this.updateInterval); } }