mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-24 02:01:19 +02:00
Code Issues Releases Wiki Activity

Fix race condition in post preview

Browse Source 
The post composer could have been closed in between scheduling and
executing the callback.

Fixes flarum/org#58.
Refs #1881.
This commit is contained in:
Franz Liedke
2020-02-07 12:17:11 +01:00
parent 1941d86c15
commit 5179221a08
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
framework/core/js/src/forum/components/ReplyPlaceholder.js
View File

@@ -52,6 +52,10 @@ export default class ReplyPlaceholder extends Component {
// body with a preview. // body with a preview.
let preview; let preview;
const updateInterval = setInterval(() => { const updateInterval = setInterval(() => {
// Since we're polling, the composer may have been closed in the meantime,
// so we bail in that case.
if (!app.composer.component) return;
const content = app.composer.component.content(); const content = app.composer.component.content();
if (preview === content) return; if (preview === content) return;