From 5206e8e1dcc460a0611bd2fa24cacd90d6510707 Mon Sep 17 00:00:00 2001 From: SychO9 Date: Wed, 24 Nov 2021 19:49:41 +0100 Subject: [PATCH] chore: 200 status codes --- .../src/Api/Controller/GlobalUpdateController.php | 2 +- .../src/Api/Controller/MajorUpdateController.php | 2 +- .../src/Api/Controller/MinorUpdateController.php | 2 +- .../src/Api/Controller/RemoveExtensionController.php | 2 +- .../src/Api/Controller/UpdateExtensionController.php | 2 +- .../package-manager/tests/integration/api/MajorUpdateTest.php | 2 +- .../package-manager/tests/integration/api/MinorUpdateTest.php | 4 ++-- .../tests/integration/api/extensions/RemoveExtensionTest.php | 2 +- .../tests/integration/api/extensions/UpdateExtensionTest.php | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) diff --git a/extensions/package-manager/src/Api/Controller/GlobalUpdateController.php b/extensions/package-manager/src/Api/Controller/GlobalUpdateController.php index 0df3ea329..5828c0c7b 100755 --- a/extensions/package-manager/src/Api/Controller/GlobalUpdateController.php +++ b/extensions/package-manager/src/Api/Controller/GlobalUpdateController.php @@ -40,6 +40,6 @@ class GlobalUpdateController implements RequestHandlerInterface new GlobalUpdate($actor) ); - return new EmptyResponse(); + return new EmptyResponse(200); } } diff --git a/extensions/package-manager/src/Api/Controller/MajorUpdateController.php b/extensions/package-manager/src/Api/Controller/MajorUpdateController.php index ee2bebfa3..5e6859e99 100755 --- a/extensions/package-manager/src/Api/Controller/MajorUpdateController.php +++ b/extensions/package-manager/src/Api/Controller/MajorUpdateController.php @@ -39,6 +39,6 @@ class MajorUpdateController implements RequestHandlerInterface new MajorUpdate($actor, $dryRun) ); - return new EmptyResponse(); + return new EmptyResponse(200); } } diff --git a/extensions/package-manager/src/Api/Controller/MinorUpdateController.php b/extensions/package-manager/src/Api/Controller/MinorUpdateController.php index 32f220146..ee930405a 100755 --- a/extensions/package-manager/src/Api/Controller/MinorUpdateController.php +++ b/extensions/package-manager/src/Api/Controller/MinorUpdateController.php @@ -40,6 +40,6 @@ class MinorUpdateController implements RequestHandlerInterface new MinorUpdate($actor) ); - return new EmptyResponse(); + return new EmptyResponse(200); } } diff --git a/extensions/package-manager/src/Api/Controller/RemoveExtensionController.php b/extensions/package-manager/src/Api/Controller/RemoveExtensionController.php index 28d144721..842d11129 100755 --- a/extensions/package-manager/src/Api/Controller/RemoveExtensionController.php +++ b/extensions/package-manager/src/Api/Controller/RemoveExtensionController.php @@ -39,6 +39,6 @@ class RemoveExtensionController implements RequestHandlerInterface new RemoveExtension($actor, $extensionId) ); - return new EmptyResponse(); + return new EmptyResponse(200); } } diff --git a/extensions/package-manager/src/Api/Controller/UpdateExtensionController.php b/extensions/package-manager/src/Api/Controller/UpdateExtensionController.php index f1f65686f..7b846c481 100755 --- a/extensions/package-manager/src/Api/Controller/UpdateExtensionController.php +++ b/extensions/package-manager/src/Api/Controller/UpdateExtensionController.php @@ -39,6 +39,6 @@ class UpdateExtensionController implements RequestHandlerInterface new UpdateExtension($actor, $extensionId) ); - return new EmptyResponse(); + return new EmptyResponse(200); } } diff --git a/extensions/package-manager/tests/integration/api/MajorUpdateTest.php b/extensions/package-manager/tests/integration/api/MajorUpdateTest.php index 04fccc25e..bd5cdc8ac 100644 --- a/extensions/package-manager/tests/integration/api/MajorUpdateTest.php +++ b/extensions/package-manager/tests/integration/api/MajorUpdateTest.php @@ -79,7 +79,7 @@ class MajorUpdateTest extends TestCase } )[0]['latest-major']; - $this->assertEquals(204, $response->getStatusCode()); + $this->assertEquals(200, $response->getStatusCode()); $this->assertPackageVersion("flarum/core", str_replace('v', '^', $newMinorCoreVersion)); $this->assertPackageVersion("flarum/tags", "*"); $this->assertPackageVersion("flarum/dummy-compatible-extension", "*"); diff --git a/extensions/package-manager/tests/integration/api/MinorUpdateTest.php b/extensions/package-manager/tests/integration/api/MinorUpdateTest.php index cb7b77a01..4321b4851 100644 --- a/extensions/package-manager/tests/integration/api/MinorUpdateTest.php +++ b/extensions/package-manager/tests/integration/api/MinorUpdateTest.php @@ -46,7 +46,7 @@ class MinorUpdateTest extends TestCase ]) ); - $this->assertEquals(204, $response->getStatusCode()); + $this->assertEquals(200, $response->getStatusCode()); $this->assertPackageVersion('flarum/tags', '*'); $this->assertPackageVersion('flarum/dummy-compatible-extension', '*'); } @@ -83,7 +83,7 @@ class MinorUpdateTest extends TestCase /** @var LastUpdateRun $lastUpdateRun */ $lastUpdateRun = $this->app()->getContainer()->make(LastUpdateRun::class); - $this->assertEquals(204, $response->getStatusCode()); + $this->assertEquals(200, $response->getStatusCode()); $this->assertPackageVersion("flarum/tags", "*"); $this->assertPackageVersion("flarum/dummy-extension", "*"); $this->assertEquals([ diff --git a/extensions/package-manager/tests/integration/api/extensions/RemoveExtensionTest.php b/extensions/package-manager/tests/integration/api/extensions/RemoveExtensionTest.php index c7a457abc..d13f494df 100644 --- a/extensions/package-manager/tests/integration/api/extensions/RemoveExtensionTest.php +++ b/extensions/package-manager/tests/integration/api/extensions/RemoveExtensionTest.php @@ -35,7 +35,7 @@ class RemoveExtensionTest extends TestCase ]) ); - $this->assertEquals(204, $response->getStatusCode()); + $this->assertEquals(200, $response->getStatusCode()); $this->assertExtensionNotExists('flarum-tags'); } diff --git a/extensions/package-manager/tests/integration/api/extensions/UpdateExtensionTest.php b/extensions/package-manager/tests/integration/api/extensions/UpdateExtensionTest.php index d19f91e9d..b40c18efc 100644 --- a/extensions/package-manager/tests/integration/api/extensions/UpdateExtensionTest.php +++ b/extensions/package-manager/tests/integration/api/extensions/UpdateExtensionTest.php @@ -35,7 +35,7 @@ class UpdateExtensionTest extends TestCase ]) ); - $this->assertEquals(204, $response->getStatusCode()); + $this->assertEquals(200, $response->getStatusCode()); $this->assertExtensionExists('flarum-tags'); }