From 521834f5da591af160b60c89adb92b4d9e325aaa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20Klabbers?= Date: Tue, 19 Nov 2019 12:47:51 +0100 Subject: [PATCH] [review] using orWhere to allow any where to follow in extensions --- src/Post/PostPolicy.php | 8 +++++--- .../api/Controller/ShowDiscussionControllerTest.php | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/Post/PostPolicy.php b/src/Post/PostPolicy.php index 6d742e368..be1825374 100644 --- a/src/Post/PostPolicy.php +++ b/src/Post/PostPolicy.php @@ -98,9 +98,11 @@ class PostPolicy extends AbstractPolicy ->whereColumn('discussions.id', 'posts.discussion_id') ->where(function ($query) use ($actor) { $query->whereRaw('1=0'); - $this->events->dispatch( - new ScopeModelVisibility(Discussion::query()->setQuery($query), $actor, 'hidePosts') - ); + $query->orWhere(function ($query) use ($actor) { + $this->events->dispatch( + new ScopeModelVisibility(Discussion::query()->setQuery($query), $actor, 'hidePosts') + ); + }); }); }); }); diff --git a/tests/integration/api/Controller/ShowDiscussionControllerTest.php b/tests/integration/api/Controller/ShowDiscussionControllerTest.php index 1dd32b2f7..55c938523 100644 --- a/tests/integration/api/Controller/ShowDiscussionControllerTest.php +++ b/tests/integration/api/Controller/ShowDiscussionControllerTest.php @@ -115,7 +115,7 @@ class ShowDiscussionControllerTest extends ApiControllerTestCase $events = app(Dispatcher::class); $events->listen(ScopeModelVisibility::class, function (ScopeModelVisibility $event) { - $event->query->orWhereRaw('1=1'); + $event->query->whereRaw('1=1'); }); $response = $this->callWith([], ['id' => 4]);