From 557fc2cd3997be974b9b61ade78fd1ba78115dba Mon Sep 17 00:00:00 2001 From: Ian Morland Date: Wed, 23 Jun 2021 17:13:31 +0100 Subject: [PATCH] Include updating of scoped tag permissions Addresses https://github.com/flarum/core/issues/2924 The rename `viewDiscussions` migration introduced for Flarum 1.0 does not take tag scoped permissions into account https://github.com/flarum/core/blob/e92c267cdec46266b633f71c2f41040731cdaf39/migrations/2021_05_10_000000_rename_permissions.php#L17 This adds a new migration to additionally rename `tagX.viewDiscussions` to `tagX.viewForum` Tested locally on an upgrade from core `beta.16` to `1.0.3` --- migrations/2021_05_10_000000_rename_permissions.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migrations/2021_05_10_000000_rename_permissions.php b/migrations/2021_05_10_000000_rename_permissions.php index 4cf906ff9..367c2d6c3 100644 --- a/migrations/2021_05_10_000000_rename_permissions.php +++ b/migrations/2021_05_10_000000_rename_permissions.php @@ -14,7 +14,7 @@ return [ $db = $schema->getConnection(); $db->table('group_permission') - ->where('permission', 'LIKE', 'viewDiscussions') + ->where('permission', 'LIKE', '%viewDiscussions') ->update(['permission' => $db->raw("REPLACE(permission, 'viewDiscussions', 'viewForum')")]); $db->table('group_permission') @@ -26,7 +26,7 @@ return [ $db = $schema->getConnection(); $db->table('group_permission') - ->where('permission', 'LIKE', 'viewForum') + ->where('permission', 'LIKE', '%viewForum') ->update(['permission' => $db->raw("REPLACE(permission, 'viewForum', 'viewDiscussions')")]); $db->table('group_permission')