mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-18 23:31:17 +02:00
Code Issues Releases Wiki Activity

Actually test IlluminateValidationExceptionHandler

Browse Source
This commit is contained in:
Toby Zerner
2016-06-05 09:25:47 +09:30
parent bdc0bd3d02
commit 55f23cf49b
1 changed files with 23 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
framework/core/tests/Flarum/Api/Handler/IlluminateValidationExceptionHandlerTest.php
View File

@@ -11,8 +11,10 @@
namespace Tests\Flarum\Api\Handler; namespace Tests\Flarum\Api\Handler;
use Exception; use Exception;
use Flarum\Api\Handler\ValidationExceptionHandler; use Flarum\Api\Handler\IlluminateValidationExceptionHandler;
use Flarum\Core\Exception\ValidationException; use Illuminate\Contracts\Validation\ValidationException;
use Illuminate\Validation\Factory;
use Symfony\Component\Translation\Translator;
use Tests\Test\TestCase; use Tests\Test\TestCase;
class IlluminateValidationExceptionHandlerTest extends TestCase class IlluminateValidationExceptionHandlerTest extends TestCase
@@ -21,12 +23,12 @@ class IlluminateValidationExceptionHandlerTest extends TestCase
public function init() public function init()
{ {
$this->handler = new ValidationExceptionHandler; $this->handler = new IlluminateValidationExceptionHandler;
} }
public function test_it_handles_familiar_exceptions() public function test_it_handles_familiar_exceptions()
{ {
$validException = new ValidationException(['messages']); $validException = new ValidationException($this->makeValidator());
$this->assertFalse($this->handler->manages(new Exception)); $this->assertFalse($this->handler->manages(new Exception));
$this->assertTrue($this->handler->manages($validException)); $this->assertTrue($this->handler->manages($validException));
@@ -34,12 +36,26 @@ class IlluminateValidationExceptionHandlerTest extends TestCase
public function test_it_creates_the_desired_output() public function test_it_creates_the_desired_output()
{ {
$this->markTestIncomplete(); $exception = new ValidationException($this->makeValidator(['foo' => ''], ['foo' => 'required']));
$exception = new ValidationException(['field' => ['Some error']]);
$response = $this->handler->handle($exception); $response = $this->handler->handle($exception);
$this->assertEquals(422, $response->getStatus()); $this->assertEquals(422, $response->getStatus());
$this->assertEquals([
[
'status' => '422',
'code' => 'validation_error',
'detail' => 'validation.required',
'source' => ['pointer' => '/data/attributes/foo']
]
], $response->getErrors());
}
private function makeValidator($data = [], $rules = [])
{
$translator = new Translator('en');
$factory = new Factory($translator);
return $factory->make($data, $rules);
} }
} }