mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-07-12 04:16:24 +02:00
Code Issues Releases Wiki Activity

Don't store PostUser instance in CommentPost (#2184)

Browse Source 
* Don't save component state in CommentPost
This commit is contained in:
Alexander Skvortsov
2020-06-18 20:10:25 -04:00
committed by GitHub
parent ed566cd18f
commit 62fe9db732
2 changed files with 6 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
js/src/forum/components/CommentPost.js
View File

@ -31,13 +31,7 @@ export default class CommentPost extends Post {
*/
this.revealContent = false;
// Create an instance of the component that displays the post's author so
// that we can force the post to rerender when the user card is shown.
this.postUser = new PostUser({ post: this.props.post });
this.subtree.check(
() => this.postUser.cardVisible,
() => this.isEditing()
);
this.subtree.check(() => this.isEditing());
}
content() {
@ -129,13 +123,12 @@ export default class CommentPost extends Post {
headerItems() {
const items = new ItemList();
const post = this.props.post;
const props = { post };
items.add('user', this.postUser.render(), 100);
items.add('meta', PostMeta.component(props));
items.add('user', PostUser.component({ post }), 100);
items.add('meta', PostMeta.component({ post }));
if (post.isEdited() && !post.isHidden()) {
items.add('edited', PostEdited.component(props));
items.add('edited', PostEdited.component({ post }));
}
// If the post is hidden, add a button that allows toggling the visibility