From 656dec65dce2be09dcb40d613e988ebc09ab3e35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20Klabbers?= Date: Wed, 30 Sep 2020 01:03:51 +0200 Subject: [PATCH] Allow easier overriding of js compiler (#2318) --- framework/core/src/Frontend/Assets.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/framework/core/src/Frontend/Assets.php b/framework/core/src/Frontend/Assets.php index a437b33cb..68768a443 100644 --- a/framework/core/src/Frontend/Assets.php +++ b/framework/core/src/Frontend/Assets.php @@ -102,7 +102,7 @@ class Assets public function makeJs(): JsCompiler { - $compiler = new JsCompiler($this->assetsDir, $this->name.'.js'); + $compiler = $this->makeJsCompiler($this->name.'.js'); $this->populate($compiler, 'js'); @@ -120,7 +120,7 @@ class Assets public function makeLocaleJs(string $locale): JsCompiler { - $compiler = new JsCompiler($this->assetsDir, $this->name.'-'.$locale.'.js'); + $compiler = $this->makeJsCompiler($this->name.'-'.$locale.'.js'); $this->populate($compiler, 'localeJs', $locale); @@ -136,6 +136,11 @@ class Assets return $compiler; } + protected function makeJsCompiler(string $filename) + { + return new JsCompiler($this->assetsDir, $filename); + } + protected function makeLessCompiler(string $filename): LessCompiler { $compiler = new LessCompiler($this->assetsDir, $filename);