From 67c1d79c5c2b56ac48758340b7c79eec5983e274 Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Tue, 13 Oct 2015 16:59:23 +1030 Subject: [PATCH] Initialise component state in init() instead of constructor --- extensions/tags/js/admin/src/components/EditTagModal.js | 4 ++-- extensions/tags/js/forum/src/components/TagDiscussionModal.js | 4 ++-- extensions/tags/js/forum/src/components/TagsPage.js | 4 +--- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/extensions/tags/js/admin/src/components/EditTagModal.js b/extensions/tags/js/admin/src/components/EditTagModal.js index 082aeca37..317835256 100644 --- a/extensions/tags/js/admin/src/components/EditTagModal.js +++ b/extensions/tags/js/admin/src/components/EditTagModal.js @@ -9,8 +9,8 @@ import tagLabel from 'flarum/tags/helpers/tagLabel'; * to create or edit a tag. */ export default class EditTagModal extends Modal { - constructor(...args) { - super(...args); + init() { + super.init(); this.tag = this.props.tag || app.store.createRecord('tags'); diff --git a/extensions/tags/js/forum/src/components/TagDiscussionModal.js b/extensions/tags/js/forum/src/components/TagDiscussionModal.js index 7280d6321..984f9f9c9 100644 --- a/extensions/tags/js/forum/src/components/TagDiscussionModal.js +++ b/extensions/tags/js/forum/src/components/TagDiscussionModal.js @@ -10,8 +10,8 @@ import tagIcon from 'flarum/tags/helpers/tagIcon'; import sortTags from 'flarum/tags/utils/sortTags'; export default class TagDiscussionModal extends Modal { - constructor(...args) { - super(...args); + init() { + super.init(); this.tags = sortTags(app.store.all('tags').filter(tag => tag.canStartDiscussion())); diff --git a/extensions/tags/js/forum/src/components/TagsPage.js b/extensions/tags/js/forum/src/components/TagsPage.js index c8c7df01c..76dfdb7ee 100644 --- a/extensions/tags/js/forum/src/components/TagsPage.js +++ b/extensions/tags/js/forum/src/components/TagsPage.js @@ -7,9 +7,7 @@ import tagLabel from 'flarum/tags/helpers/tagLabel'; import sortTags from 'flarum/tags/utils/sortTags'; export default class TagsPage extends Component { - constructor(...args) { - super(...args); - + init() { this.tags = sortTags(app.store.all('tags').filter(tag => !tag.parent())); app.current = this;