From 6846f4232cad96811d0dad11c1d6016da40f6893 Mon Sep 17 00:00:00 2001
From: IanM <16573496+imorland@users.noreply.github.com>
Date: Thu, 3 Oct 2024 07:25:00 +0100
Subject: [PATCH] fix: js error as guest on DiscussionListItem (#4056)

---
 .../forum/components/DiscussionListItem.tsx   | 20 +++++++++----------
 1 file changed, 9 insertions(+), 11 deletions(-)

diff --git a/framework/core/js/src/forum/components/DiscussionListItem.tsx b/framework/core/js/src/forum/components/DiscussionListItem.tsx
index b61d4abfb..dd5ebba47 100644
--- a/framework/core/js/src/forum/components/DiscussionListItem.tsx
+++ b/framework/core/js/src/forum/components/DiscussionListItem.tsx
@@ -74,7 +74,7 @@ export default class DiscussionListItem<CustomAttrs extends IDiscussionListItemA
     const discussion = this.attrs.discussion;
     const controls = DiscussionControls.controls(discussion, this).toArray();
 
-    items.add('controls', this.controlsView(controls), 100);
+    !!controls.length && items.add('controls', this.controlsView(controls), 100);
     items.add('slidableUnderneath', this.slidableUnderneathView(), 90);
     items.add('content', this.contentView(), 80);
 
@@ -83,16 +83,14 @@ export default class DiscussionListItem<CustomAttrs extends IDiscussionListItemA
 
   controlsView(controls: Mithril.ChildArray): Mithril.Children {
     return (
-      !!controls.length && (
-        <Dropdown
-          icon="fas fa-ellipsis-v"
-          className="DiscussionListItem-controls"
-          buttonClassName="Button Button--icon Button--flat Slidable-underneath Slidable-underneath--right"
-          accessibleToggleLabel={app.translator.trans('core.forum.discussion_controls.toggle_dropdown_accessible_label')}
-        >
-          {controls}
-        </Dropdown>
-      )
+      <Dropdown
+        icon="fas fa-ellipsis-v"
+        className="DiscussionListItem-controls"
+        buttonClassName="Button Button--icon Button--flat Slidable-underneath Slidable-underneath--right"
+        accessibleToggleLabel={app.translator.trans('core.forum.discussion_controls.toggle_dropdown_accessible_label')}
+      >
+        {controls}
+      </Dropdown>
     );
   }