From 6898e0acbb04e33d711f71f6918479bc36d2d68e Mon Sep 17 00:00:00 2001 From: Toby Zerner Date: Mon, 30 Mar 2015 16:17:04 +1030 Subject: [PATCH] Refactor Flarum\Web and Flarum\Admin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - In order to be consistent with the Ember/LESS naming scheme, renamed Flarum\Web to Flarum\Forum. - Moved common classes into Flarum\Support so that Flarum\Admin doesn’t depend on Flarum\Forum. Also moved Actor into Flarum\Support as it doesn’t belong in the domain. --- src/Admin/Actions/IndexAction.php | 2 +- src/Admin/AdminServiceProvider.php | 2 +- .../LoginWithCookieAndCheckAdmin.php | 2 +- src/Api/Actions/Activity/IndexAction.php | 2 +- src/Api/Actions/BaseAction.php | 4 +-- src/Api/Actions/Discussions/IndexAction.php | 2 +- src/Api/Actions/Discussions/ShowAction.php | 2 +- src/Api/Actions/Notifications/IndexAction.php | 2 +- src/Api/Actions/Posts/IndexAction.php | 2 +- src/Api/Actions/Posts/ShowAction.php | 2 +- src/Api/Actions/Users/IndexAction.php | 2 +- src/Api/Actions/Users/ShowAction.php | 2 +- src/Api/ApiServiceProvider.php | 4 +-- src/Api/Middleware/LoginWithHeader.php | 2 +- src/Api/Serializers/BaseSerializer.php | 6 ++-- src/Forum/Actions/BaseAction.php | 13 +++++++ src/{Web => Forum}/Actions/ConfirmAction.php | 4 +-- src/{Web => Forum}/Actions/IndexAction.php | 10 +++--- src/{Web => Forum}/Actions/LoginAction.php | 6 ++-- src/{Web => Forum}/Actions/LogoutAction.php | 6 ++-- .../Actions/MakesRememberCookie.php | 2 +- .../Events/CommandWillBeDispatched.php | 2 +- src/{Web => Forum}/Events/UserLoggedIn.php | 2 +- src/{Web => Forum}/Events/UserLoggedOut.php | 2 +- .../ForumServiceProvider.php} | 11 +++--- .../Middleware/LoginWithCookie.php | 4 +-- src/Forum/routes.php | 34 +++++++++++++++++++ src/{Web/Actions => Support}/Action.php | 10 +----- src/{Core => }/Support/Actor.php | 2 +- src/{Web => Support}/AssetManager.php | 2 +- src/Web/routes.php | 34 ------------------- 31 files changed, 94 insertions(+), 88 deletions(-) create mode 100644 src/Forum/Actions/BaseAction.php rename src/{Web => Forum}/Actions/ConfirmAction.php (92%) rename src/{Web => Forum}/Actions/IndexAction.php (85%) rename src/{Web => Forum}/Actions/LoginAction.php (86%) rename src/{Web => Forum}/Actions/LogoutAction.php (80%) rename src/{Web => Forum}/Actions/MakesRememberCookie.php (81%) rename src/{Web => Forum}/Events/CommandWillBeDispatched.php (84%) rename src/{Web => Forum}/Events/UserLoggedIn.php (85%) rename src/{Web => Forum}/Events/UserLoggedOut.php (81%) rename src/{Web/WebServiceProvider.php => Forum/ForumServiceProvider.php} (70%) rename src/{Web => Forum}/Middleware/LoginWithCookie.php (88%) create mode 100755 src/Forum/routes.php rename src/{Web/Actions => Support}/Action.php (60%) rename src/{Core => }/Support/Actor.php (89%) rename src/{Web => Support}/AssetManager.php (99%) delete mode 100755 src/Web/routes.php diff --git a/src/Admin/Actions/IndexAction.php b/src/Admin/Actions/IndexAction.php index da4701ec6..816e9d712 100644 --- a/src/Admin/Actions/IndexAction.php +++ b/src/Admin/Actions/IndexAction.php @@ -1,6 +1,6 @@ app['Flarum\Core\Support\Actor']); + BaseSerializer::setActor($this->app['Flarum\Support\Actor']); } /** @@ -29,6 +29,6 @@ class ApiServiceProvider extends ServiceProvider */ public function register() { - $this->app->singleton('Flarum\Core\Support\Actor'); + $this->app->singleton('Flarum\Support\Actor'); } } diff --git a/src/Api/Middleware/LoginWithHeader.php b/src/Api/Middleware/LoginWithHeader.php index e8e7f78cc..d3384b1ab 100644 --- a/src/Api/Middleware/LoginWithHeader.php +++ b/src/Api/Middleware/LoginWithHeader.php @@ -1,7 +1,7 @@ bus->dispatch($command); + } +} diff --git a/src/Web/Actions/ConfirmAction.php b/src/Forum/Actions/ConfirmAction.php similarity index 92% rename from src/Web/Actions/ConfirmAction.php rename to src/Forum/Actions/ConfirmAction.php index 510bfe7d7..61eecf602 100644 --- a/src/Web/Actions/ConfirmAction.php +++ b/src/Forum/Actions/ConfirmAction.php @@ -1,11 +1,11 @@ -with('title', Config::get('flarum::forum_title', 'Flarum Demo Forum')) - ->with('styles', app('flarum.web.assetManager')->getCSSFiles()) - ->with('scripts', app('flarum.web.assetManager')->getJSFiles()) + ->with('styles', app('flarum.forum.assetManager')->getCSSFiles()) + ->with('scripts', app('flarum.forum.assetManager')->getJSFiles()) ->with('config', $config) ->with('content', '') ->with('data', $data) diff --git a/src/Web/Actions/LoginAction.php b/src/Forum/Actions/LoginAction.php similarity index 86% rename from src/Web/Actions/LoginAction.php rename to src/Forum/Actions/LoginAction.php index 665e7e0c3..f4f55a7f3 100644 --- a/src/Web/Actions/LoginAction.php +++ b/src/Forum/Actions/LoginAction.php @@ -1,10 +1,10 @@ -loadViewsFrom($root.'/views', 'flarum.web'); + $this->loadViewsFrom($root.'/views', 'flarum.forum'); - $assetManager = $this->app['flarum.web.assetManager']; + $assetManager = $this->app['flarum.forum.assetManager']; $assetManager->addFile([ $root.'/ember/forum/dist/assets/vendor.js', @@ -37,7 +38,7 @@ class WebServiceProvider extends ServiceProvider */ public function register() { - $this->app['flarum.web.assetManager'] = $this->app->share(function ($app) { + $this->app['flarum.forum.assetManager'] = $this->app->share(function ($app) { return new AssetManager($app['files'], $app['path.public'].'/flarum', 'forum'); }); } diff --git a/src/Web/Middleware/LoginWithCookie.php b/src/Forum/Middleware/LoginWithCookie.php similarity index 88% rename from src/Web/Middleware/LoginWithCookie.php rename to src/Forum/Middleware/LoginWithCookie.php index e496ee133..0eaa71aae 100644 --- a/src/Web/Middleware/LoginWithCookie.php +++ b/src/Forum/Middleware/LoginWithCookie.php @@ -1,6 +1,6 @@ -app->make($class); + $request = $this->app['request']->instance(); + $parameters = $this->app['router']->current()->parameters(); + return $action->handle($request, $parameters); + }; +}; + +Route::group(['middleware' => 'Flarum\Forum\Middleware\LoginWithCookie'], function () use ($action) { + + Route::get('/', [ + 'as' => 'flarum.forum.index', + 'uses' => $action('Flarum\Forum\Actions\IndexAction') + ]); + + Route::get('logout', [ + 'as' => 'flarum.forum.logout', + 'uses' => $action('Flarum\Forum\Actions\LogoutAction') + ]); + +}); + +Route::post('login', [ + 'as' => 'flarum.forum.login', + 'uses' => $action('Flarum\Forum\Actions\LoginAction') +]); + +Route::get('confirm/{id}/{token}', [ + 'as' => 'flarum.forum.confirm', + 'uses' => $action('Flarum\Forum\Actions\ConfirmAction') +]); diff --git a/src/Web/Actions/Action.php b/src/Support/Action.php similarity index 60% rename from src/Web/Actions/Action.php rename to src/Support/Action.php index bccb78908..31599a950 100644 --- a/src/Web/Actions/Action.php +++ b/src/Support/Action.php @@ -1,9 +1,7 @@ -call($params); } - - protected function dispatch($command, $params = []) - { - event(new CommandWillBeDispatched($command, $params)); - return $this->bus->dispatch($command); - } } diff --git a/src/Core/Support/Actor.php b/src/Support/Actor.php similarity index 89% rename from src/Core/Support/Actor.php rename to src/Support/Actor.php index 46993ad5f..18e43ea43 100755 --- a/src/Core/Support/Actor.php +++ b/src/Support/Actor.php @@ -1,4 +1,4 @@ -app->make($class); - $request = $this->app['request']->instance(); - $parameters = $this->app['router']->current()->parameters(); - return $action->handle($request, $parameters); - }; -}; - -Route::group(['middleware' => 'Flarum\Web\Middleware\LoginWithCookie'], function () use ($action) { - - Route::get('/', [ - 'as' => 'flarum.index', - 'uses' => $action('Flarum\Web\Actions\IndexAction') - ]); - - Route::get('logout', [ - 'as' => 'flarum.logout', - 'uses' => $action('Flarum\Web\Actions\LogoutAction') - ]); - -}); - -Route::post('login', [ - 'as' => 'flarum.login', - 'uses' => $action('Flarum\Web\Actions\LoginAction') -]); - -Route::get('confirm/{id}/{token}', [ - 'as' => 'flarum.confirm', - 'uses' => $action('Flarum\Web\Actions\ConfirmAction') -]);