mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-04 23:47:32 +02:00
Code Issues Releases Wiki Activity

Major refactor and improvements

Browse Source 
- Reorganised all namespaces and class names for consistency and structure. Following PSR bylaws (Abstract prefix, Interface/Trait suffix).
  - Move models into root of Core, because writing `use Flarum\Core\Discussion` is nice. Namespace the rest by type. (Namespacing by entity was too arbitrary.)
  - Moved some non-domain stuff out of Core: Database, Formatter, Settings.
  - Renamed config table and all references to "settings" for consistency.
  - Remove Core class and add url()/isInstalled()/inDebugMode() as instance methods of Foundation\Application.
  - Cleanup, docblocking, etc.

- Improvements to HTTP architecture
  - API and forum/admin Actions are now actually all the same thing (simple PSR-7 Request handlers), renamed to Controllers.
  - Upgrade to tobscure/json-api 0.2 branch.
  - Where possible, moved generic functionality to tobscure/json-api (e.g. pagination links). I'm quite happy with the backend balance now re: #262

- Improvements to other architecture
  - Use Illuminate's Auth\Access\Gate interface/implementation instead of our old Locked trait. We still use events to actually determine the permissions though. Our Policy classes are actually glorified event subscribers.
  - Extract model validation into Core\Validator classes.
  - Make post visibility permission stuff much more efficient and DRY.

- Renamed Flarum\Event classes for consistency. ref #246
  - `Configure` prefix for events dedicated to configuring an object.
  - `Get` prefix for events whose listeners should return something.
  - `Prepare` prefix when a variable is passed by reference so it can be modified.
  - `Scope` prefix when a query builder is passed.

- Miscellaneous improvements/bug-fixes. I'm easily distracted!
  - Increase default height of post composer.
  - Improve post stream redraw flickering in Safari by keying loading post placeholders with their IDs. ref #451
  - Use a PHP JavaScript minification library for minifying TextFormatter's JavaScript, instead of ClosureCompilerService (can't rely on external service!)
  - Use UrlGenerator properly in various places. closes #123
  - Make Api\Client return Response object. closes #128
  - Allow extensions to specify custom icon images.
  - Allow external API/admin URLs to be optionally specified in config.php. If the value or "url" is an array, we look for the corresponding path inside. Otherwise, we append the path to the base URL, using the corresponding value in "paths" if present. closes #244
This commit is contained in:
Toby Zerner
2015-10-08 14:28:02 +10:30
parent b667cd4d0c
commit 6bf93ae9f7
434 changed files with 8676 additions and 7997 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
framework/core/migrations/2015_02_24_000000_create_access_tokens_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateAccessTokensTable extends Migration
class CreateAccessTokensTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('access_tokens', function (Blueprint $table) {
@@ -30,11 +25,6 @@ class CreateAccessTokensTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('access_tokens');

16
framework/core/migrations/2015_02_24_000000_create_api_keys_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateApiKeysTable extends Migration
class CreateApiKeysTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('api_keys', function (Blueprint $table) {
@@ -27,11 +22,6 @@ class CreateApiKeysTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('api_keys');

16
framework/core/migrations/2015_02_24_000000_create_config_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateConfigTable extends Migration
class CreateConfigTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('config', function (Blueprint $table) {
@@ -28,11 +23,6 @@ class CreateConfigTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('config');

16
framework/core/migrations/2015_02_24_000000_create_discussions_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateDiscussionsTable extends Migration
class CreateDiscussionsTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('discussions', function (Blueprint $table) {
@@ -40,11 +35,6 @@ class CreateDiscussionsTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('discussions');

16
framework/core/migrations/2015_02_24_000000_create_email_tokens_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateEmailTokensTable extends Migration
class CreateEmailTokensTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('email_tokens', function (Blueprint $table) {
@@ -30,11 +25,6 @@ class CreateEmailTokensTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('email_tokens');

16
framework/core/migrations/2015_02_24_000000_create_groups_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateGroupsTable extends Migration
class CreateGroupsTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('groups', function (Blueprint $table) {
@@ -31,11 +26,6 @@ class CreateGroupsTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('groups');

16
framework/core/migrations/2015_02_24_000000_create_notifications_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateNotificationsTable extends Migration
class CreateNotificationsTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('notifications', function (Blueprint $table) {
@@ -36,11 +31,6 @@ class CreateNotificationsTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('notifications');

16
framework/core/migrations/2015_02_24_000000_create_password_tokens_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreatePasswordTokensTable extends Migration
class CreatePasswordTokensTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('password_tokens', function (Blueprint $table) {
@@ -29,11 +24,6 @@ class CreatePasswordTokensTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('password_tokens');

16
framework/core/migrations/2015_02_24_000000_create_permissions_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreatePermissionsTable extends Migration
class CreatePermissionsTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('permissions', function (Blueprint $table) {
@@ -29,11 +24,6 @@ class CreatePermissionsTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('permissions');

16
framework/core/migrations/2015_02_24_000000_create_posts_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreatePostsTable extends Migration
class CreatePostsTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('posts', function (Blueprint $table) {
@@ -46,11 +41,6 @@ class CreatePostsTable extends Migration
$this->schema->getConnection()->statement('ALTER TABLE '.$prefix.'posts ADD FULLTEXT content (content)');
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('posts');

16
framework/core/migrations/2015_02_24_000000_create_users_discussions_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateUsersDiscussionsTable extends Migration
class CreateUsersDiscussionsTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('users_discussions', function (Blueprint $table) {
@@ -31,11 +26,6 @@ class CreateUsersDiscussionsTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('users_discussions');

16
framework/core/migrations/2015_02_24_000000_create_users_groups_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateUsersGroupsTable extends Migration
class CreateUsersGroupsTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('users_groups', function (Blueprint $table) {
@@ -29,11 +24,6 @@ class CreateUsersGroupsTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('users_groups');

16
framework/core/migrations/2015_02_24_000000_create_users_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateUsersTable extends Migration
class CreateUsersTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('users', function (Blueprint $table) {
@@ -40,11 +35,6 @@ class CreateUsersTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('users');

16
framework/core/migrations/2015_09_15_000000_create_auth_tokens_table.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Migrations\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
class CreateAuthTokensTable extends Migration
class CreateAuthTokensTable extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->create('auth_tokens', function (Blueprint $table) {
@@ -29,11 +24,6 @@ class CreateAuthTokensTable extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->drop('auth_tokens');

16
framework/core/migrations/2015_09_20_224327_add_hide_to_discussions.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
use Flarum\Migrations\Migration;
class AddHideToDiscussions extends Migration
class AddHideToDiscussions extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->table('discussions', function (Blueprint $table) {
@@ -28,11 +23,6 @@ class AddHideToDiscussions extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->table('discussions', function (Blueprint $table) {

16
framework/core/migrations/2015_09_22_030432_rename_notification_read_time.php
View File

@@ -8,18 +8,13 @@
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migrations;
namespace Flarum\Core\Migration;
use Flarum\Database\AbstractMigration;
use Illuminate\Database\Schema\Blueprint;
use Flarum\Migrations\Migration;
class RenameNotificationReadTime extends Migration
class RenameNotificationReadTime extends AbstractMigration
{
/**
* Run the migrations.
*
* @return void
*/
public function up()
{
$this->schema->table('users', function (Blueprint $table) {
@@ -27,11 +22,6 @@ class RenameNotificationReadTime extends Migration
});
}
/**
* Reverse the migrations.
*
* @return void
*/
public function down()
{
$this->schema->table('users', function (Blueprint $table) {

26
framework/core/migrations/2015_10_07_130531_rename_config_to_settings.php Normal file
View File

@@ -0,0 +1,26 @@
<?php
/*
* This file is part of Flarum.
*
* (c) Toby Zerner <toby.zerner@gmail.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Flarum\Core\Migration;
use Flarum\Database\AbstractMigration;
class RenameConfigToSettings extends AbstractMigration
{
public function up()
{
$this->schema->rename('config', 'settings');
}
public function down()
{
$this->schema->rename('settings', 'config');
}
}