mirror/php-flarum
1
0
Fork 0
mirror of https://github.com/flarum/core.git synced 2025-08-15 12:54:47 +02:00
Code Issues Releases Wiki Activity

[1.x] fix: change length of email field (#4117)

Browse Source 
* test: write failing tests for email length

* style: formatting

* style: formatting

* fix: change length of email field

* test: write test for email with too long local part

* style: formatting

* chore: remove unnecessary tests
This commit is contained in:
Davide Iadeluca
2024-11-19 17:49:17 +01:00
committed by GitHub
parent 8eb56b16cf
commit 6c89f8161e
2 changed files with 90 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
framework/core/migrations/2024_11_18_000000_increase_email_field_length.php Normal file
View File

@@ -0,0 +1,25 @@
<?php
/*
* This file is part of Flarum.
*
* For detailed copyright and license information, please view the
* LICENSE file that was distributed with this source code.
*/
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Schema\Builder;
return [
'up' => function (Builder $schema) {
$schema->table('users', function (Blueprint $table) {
$table->string('email', 254)->change();
});
},
'down' => function (Builder $schema) {
$schema->table('users', function (Blueprint $table) {
$table->string('email', 150)->change();
});
}
];

65
framework/core/tests/integration/api/users/CreateTest.php
View File

@@ -139,6 +139,71 @@ class CreateTest extends TestCase
$this->assertEquals(1, $user->is_email_confirmed);
}
/**
* @test
*/
public function admin_can_create_user_with_longest_valid_email()
{
$localPart = str_repeat('a', 64);
$domain = str_repeat('a', 61).'.'.str_repeat('a', 60).'.'.str_repeat('a', 60).'.local';
$email = $localPart.'@'.$domain;
$response = $this->send(
$this->request(
'POST',
'/api/users',
[
'authenticatedAs' => 1,
'json' => [
'data' => [
'attributes' => [
'username' => 'test',
'password' => 'too-obscure',
'email' => $email,
],
]
],
]
)
);
$this->assertEquals(201, $response->getStatusCode());
/** @var User $user */
$user = User::where('username', 'test')->firstOrFail();
$this->assertEquals($email, $user->email);
}
/**
* @test
*/
public function admin_cannot_create_user_with_invalid_email_length()
{
$email = str_repeat('a', 65).'@'.str_repeat('a', 256).'.local';
$response = $this->send(
$this->request(
'POST',
'/api/users',
[
'authenticatedAs' => 1,
'json' => [
'data' => [
'attributes' => [
'username' => 'test',
'password' => 'too-obscure',
'email' => $email,
],
]
],
]
)
);
$this->assertEquals(422, $response->getStatusCode());
}
/**
* @test
*/